Fix: Update armor crate description

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.72k stars 3.46k forks source link

Fix: Update armor crate description #33414

Open Plykiya opened 3 days ago

Plykiya commented 3 days ago

About the PR

Fixes the description and icon of the armor crate to accurately reflect what it is. Also updated the non-lethal crate description.

Why / Balance

It's just wrong.

Technical details

yml

Media

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

fix: Cargo armor crate now correctly indicates that it contains bulletproof vests.

Aeshus commented 2 days ago

Would it be relevant for this PR to also correct the Swat Crate's erroneous description? It states it requires Armory access when it actually only requires Security.

https://github.com/space-wizards/space-station-14/blob/a5e589f6ce8a97f0cc6177ce2361ff999f457069/Resources/Prototypes/Catalog/Fills/Crates/security.yml#L43-L48

Alternatively, it could make sense to make a new PR to fix it and require Armory access (and leave it out of the scope of this PR).

Plykiya commented 2 days ago

Would it be relevant for this PR to also correct the Swat Crate's erroneous description? It states it requires Armory access when it actually only requires Security.

https://github.com/space-wizards/space-station-14/blob/a5e589f6ce8a97f0cc6177ce2361ff999f457069/Resources/Prototypes/Catalog/Fills/Crates/security.yml#L43-L48

Alternatively, it could make sense to make a new PR to fix it and require Armory access (and leave it out of the scope of this PR).

I did make another PR for that about 10 minutes after this PR.

Aeshus commented 2 days ago

Oh goodie!