space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.72k stars 3.46k forks source link

Wizard Mind Swap Spell #33416

Open ActiveMammmoth opened 3 days ago

ActiveMammmoth commented 3 days ago

About the PR

I added mind swap spell for Wizard.

Why / Balance

Granted permission by KeronSHB, they're in charge of the wizard/magic PR freeze. This is a spell they want.

I can't really discuss how this would affect game balance until Wizard is actually introduced into the game. I think it'll be funny though.

Technical details

I added MindSwapSpellEvent and mindswap_spell.yml files. Added lines to SharedMagicSystem, to spellbook catalogue and to localization files.

Only potential issue is the presence of any components that should be attached to the MindComponent but are instead attached to the physical body. I figured that is a separate PR.

Media

https://github.com/user-attachments/assets/7e7b1f42-5ca8-4e3c-891a-1ff761c33892

Requirements

muburu commented 3 days ago

does this work on non humanoid entities?? could you swap into a space dragon to become a wizard dragon??

ActiveMammmoth commented 2 days ago

does this work on non humanoid entities?? could you swap into a space dragon to become a wizard dragon??

Currently: Yes.

HerCoyote23 commented 2 days ago

It's worth noting that in ss13 this knocked both the wizard and the target unconscious for like ~30 seconds iirc. That's not to say that that's how the spell should be, and I'm pretty interested in the implications of this version. That's just how the spell typically is.

The048 commented 2 days ago

While I understand that the concept of this is pretty interesting, this just seems like it would be extremely annoying and unfun to play against. Giving an antagonist who is already really strong access to a borderline get-out-of-jail-free card just seems like a bad idea. This is especially so with how it seems to be completely instant and unavoidable when used, and can very possibly just instantly win a fight for the wizard [such as when fighting someone who has better weapons than you].

Aisu9 commented 2 days ago

While I understand that the concept of this is very cool, this just seems like it would be extremely annoying and unfun to play against. Giving an antagonist who is already really strong access to a borderline get-out-of-jail-free card just seems like a bad idea. This is especially so with how it seems to be completely instant and unavoidable when used, and can very possibly just instantly win a fight for the wizard [such as when fighting someone who has better weapons than you].

just so you know, Wizard spells aren't ALL about blowing things ot bits, they have a wide selection of defensive/control spells mind swap, petrification/animation are ones of many others. The 30 seconds of unconsciousness following mind swapping on SS13 is giving the wizard away and still make it very dangerous ot use in an absolute 1v1

The048 commented 2 days ago

While I understand that the concept of this is very cool, this just seems like it would be extremely annoying and unfun to play against. Giving an antagonist who is already really strong access to a borderline get-out-of-jail-free card just seems like a bad idea. This is especially so with how it seems to be completely instant and unavoidable when used, and can very possibly just instantly win a fight for the wizard [such as when fighting someone who has better weapons than you].

just so you know, Wizard spells aren't ALL about blowing things ot bits, they have a wide selection of defensive/control spells mind swap, petrification/animation are ones of many others. The 30 seconds of unconsciousness following mind swapping on SS13 is giving the wizard away and still make it very dangerous ot use in an absolute 1v1

I understand what you're saying, but this PR makes no mention of, and has no clear changes that indicate, a 30 second unconsciousness period, especially given the video attached. And unless said unconsciousness is added, this could easily be ridiculously overpowered in a variety of different ways, from faking a mind swap, instantly winning a 1v1 against a superior enemy, to just being able to instantly take the heat off of oneself and easily round-remove someone with a completely instant ability with no telegraph or way to counter. In fact, this could very well still be overpowered even if it did have an unconsciousness period, since this would effectively just be a DNA scrambler implant, which is already really strong. Also, I know this is most likely a personal gripe, but I really don't like the idea of being able to permanently and potentially irreversibly change someone's character for the rest of the round.

Aisu9 commented 2 days ago

While I understand that the concept of this is very cool, this just seems like it would be extremely annoying and unfun to play against. Giving an antagonist who is already really strong access to a borderline get-out-of-jail-free card just seems like a bad idea. This is especially so with how it seems to be completely instant and unavoidable when used, and can very possibly just instantly win a fight for the wizard [such as when fighting someone who has better weapons than you].

just so you know, Wizard spells aren't ALL about blowing things ot bits, they have a wide selection of defensive/control spells mind swap, petrification/animation are ones of many others. The 30 seconds of unconsciousness following mind swapping on SS13 is giving the wizard away and still make it very dangerous ot use in an absolute 1v1

I understand what you're saying, but this PR makes no mention of, and has no clear changes that indicate, a 30 second unconsciousness period, especially given the video attached. And unless said unconsciousness is added, this could easily be ridiculously overpowered in a variety of different ways, from faking a mind swap, instantly winning a 1v1 against a superior enemy, to just being able to instantly take the heat off of oneself and easily round-remove someone with a completely instant ability with no telegraph or way to counter. In fact, this could very well still be overpowered even if it did have an unconsciousness period, since this would effectively just be a DNA scrambler implant, which is already really strong. Also, I know this is most likely a personal gripe, but I really don't like the idea of being able to permanently and potentially irreversibly change someone's character for the rest of the round.

the aim of this PR is to aim a degree of parity from SS13, they should consider bringing everything that was made to balance this feature. unconsciousness, very long cooldown and absence of metaprotection specificaly for this spell

Dragonjspider commented 2 days ago

While I understand that the concept of this is very cool, this just seems like it would be extremely annoying and unfun to play against. Giving an antagonist who is already really strong access to a borderline get-out-of-jail-free card just seems like a bad idea. This is especially so with how it seems to be completely instant and unavoidable when used, and can very possibly just instantly win a fight for the wizard [such as when fighting someone who has better weapons than you].

just so you know, Wizard spells aren't ALL about blowing things ot bits, they have a wide selection of defensive/control spells mind swap, petrification/animation are ones of many others. The 30 seconds of unconsciousness following mind swapping on SS13 is giving the wizard away and still make it very dangerous ot use in an absolute 1v1

I understand what you're saying, but this PR makes no mention of, and has no clear changes that indicate, a 30 second unconsciousness period, especially given the video attached. And unless said unconsciousness is added, this could easily be ridiculously overpowered in a variety of different ways, from faking a mind swap, instantly winning a 1v1 against a superior enemy, to just being able to instantly take the heat off of oneself and easily round-remove someone with a completely instant ability with no telegraph or way to counter. In fact, this could very well still be overpowered even if it did have an unconsciousness period, since this would effectively just be a DNA scrambler implant, which is already really strong. Also, I know this is most likely a personal gripe, but I really don't like the idea of being able to permanently and potentially irreversibly change someone's character for the rest of the round.

I mean an easy way to make it far more balanced is probably not letting it work on mindshielded people, but that's more if someone higher up agrees with it being too unbalanced overall. Personally, I don't see this as too frustrating, especially if it means security has to be more careful with who they shoot. Worst case scenario, sec decides to shoot everyone who has the same powers as the wizard did from 30 minutes ago that they clearly killed, in which case, that just sounds like security cutting corners in my opinion.

Thatonestomf commented 2 days ago

Most wizard spells in ss13 required full wiz attire to work, and those that did are weakened, a wizard mind swaping would be severely neutered unless they some how mindswapped with say.... a dragon or something. Oh and wizard is like a 1 man nukie team in sheer destruction, a mind swap is nothing compared to gibing touch and fireball... those are the ones that win you any 1v1

ActiveMammmoth commented 2 days ago

I understand what you're saying, but this PR makes no mention of, and has no clear changes that indicate, a 30 second unconsciousness period, especially given the video attached. And unless said unconsciousness is added, this could easily be ridiculously overpowered in a variety of different ways, from faking a mind swap, instantly winning a 1v1 against a superior enemy, to just being able to instantly take the heat off of oneself and easily round-remove someone with a completely instant ability with no telegraph or way to counter. In fact, this could very well still be overpowered even if it did have an unconsciousness period, since this would effectively just be a DNA scrambler implant, which is already really strong. Also, I know this is most likely a personal gripe, but I really don't like the idea of being able to permanently and potentially irreversibly change someone's character for the rest of the round.

I can absolutely add a 30 second unconsciousness period if that would feel more balanced. If the smite spell, which is currently in the game, makes it to the final wizard, they already can instantly win 1v1s by using that. Wizard's spells are all very powerful, but it's just one wizard versus the entire station. Wizard will be a rare antagonist and won't be explicitly always a direct enemy, we have yet to nail their goals down currently but we want them to be goofy and disruptive over just bluntly killing people.

I could also add a way to reverse the mind swap. Maybe after wizard dies, everyone that's been swapped will return to their original bodies? Or sci could research some tech that grants access to a mind-swapping machine?

Kadeo64 commented 2 days ago

I could also add a way to reverse the mind swap. Maybe after wizard dies, everyone that's been swapped will return to their original bodies? Or sci could research some tech that grants access to a mind-swapping machine?

I think after wizard death would probably be fine? or maybe if someone's mind swap is not directly connected to the wizard anymore (like, the wizard has swapped 3-4 more times and isn't in your body or the person you're currently in), you automatically swap back after a few minutes to prevent the entire station from being mind-swapped at once