space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.72k stars 3.46k forks source link

Makes admins not count towards the playercount cap #33424

Open deathride58 opened 2 days ago

deathride58 commented 2 days ago

About the PR

This is a straight-forward PR, making it so that admins don't count towards the playercount cap. This is controlled by the new admin.admins_count_for_max_players cvar

Why / Balance

Currently, admins bypass the playercount cap entirely, meaning it's very common to see the servers end up escalating beyond their actual playercount cap. This means that when an admin joins while the server's at the cap, players have to wait for way longer than necessary for more than just one person to leave if they want to join the server, which is immensely frustrating for players. Simple fix: making it so that those who are able to bypass the playercount cap don't count towards it either.

Technical details

This adds a new CVar controlling whether admins count towards the playercount cap (if true, then it behaves exactly how the playercount cap behaved before).

When that CVar is false, the number of active admins gets subtracted from the current playercount during connection checks that care about the playercount.

Media

N/A

Requirements

Breaking changes

N/A

Changelog

:cl: Bhijn and Myr