Make unknown shuttle events trigger an announcement

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.72k stars 3.46k forks source link

Make unknown shuttle events trigger an announcement #33450

Open Winkarst-cpu opened 18 hours ago

Winkarst-cpu commented 18 hours ago

About the PR

Makes unknown shuttle events trigger an announcement.

Why / Balance

Fixes #33235.

Technical details

Media

https://github.com/user-attachments/assets/fd2184b3-09aa-4fd3-976a-d023dae2ac22

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

fix: Now unknown shuttle events trigger an announcement.

Winkarst-cpu commented 17 hours ago

Failed labels check is wild.

Stewie523 commented 12 hours ago

this seems like it'll be very annoying considering how many shuttle events we get.

UbaserB commented 12 hours ago

this seems like it'll be very annoying considering how many shuttle events we get.

It's tuned far too high right now lol, I'm pretty sure we decided on 1 shuttle per round max but the pr that added new shuttles was merged with some.. mistakes because the sheer size made it hard to review.

Winkarst-cpu commented 7 hours ago

Reducing unknown shuttle events is a thing for another PR ig. Main theme of this one is to just fix the announcements.