space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.73k stars 3.47k forks source link

Alert resprite #33455

Open Flareguy opened 3 days ago

Flareguy commented 3 days ago

About the PR

Resprites all "status effect" alerts to be more consistent. Does not touch "movement" effects like weightless, stunned, etc.

alerts resprite workspace

Why / Balance

Alerts, for the most part, have always been really inconsistent and difficult to understand / parse unless you actually know what they're already telling you. This PR hopefully seeks to rectify that by introducing much better iconography & generally cleaner looking spritework. The yellow warning state of an alert signifies you should be attentive / that the alert will transition in to a dangerous state eventually. A flashing sign indicates you are actively dying / something needs immediate attention.

This also makes the alerts colorblind-friendly for the most part.

Technical details

Changes line 417 in BloodstreamSystem.cs from 10 to 4, so that the 5-level blood alerts actually display without the game crashing.

Media

Content.Client_QvsMJyvi9T.webm

Requirements

Breaking changes

Changelog :cl:

github-actions[bot] commented 3 days ago

RSI Diff Bot; head commit b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea merging into a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Alerts/bleed.rsi

| State | Old | New | Status | --- | --- | --- | --- | | bleed0 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed0.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/bleed.rsi/bleed0.png) | Modified | bleed1 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed1.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/bleed.rsi/bleed1.png) | Modified | bleed2 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed2.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/bleed.rsi/bleed2.png) | Modified | bleed3 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed3.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/bleed.rsi/bleed3.png) | Modified | bleed4 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed4.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/bleed.rsi/bleed4.png) | Modified | bleed10 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed10.png) | ![]() | Removed | bleed5 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed5.png) | ![]() | Removed | bleed6 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed6.png) | ![]() | Removed | bleed7 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed7.png) | ![]() | Removed | bleed8 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed8.png) | ![]() | Removed | bleed9 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/bleed.rsi/bleed9.png) | ![]() | Removed

Resources/Textures/Interface/Alerts/breathing.rsi

| State | Old | New | Status | --- | --- | --- | --- | | not_enough_co2 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_co2.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_co2.png) | Modified | not_enough_nitro | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_nitro.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_nitro.png) | Modified | not_enough_oxy | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_oxy.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_oxy.png) | Modified | not_enough_tox | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_tox.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/not_enough_tox.png) | Modified | too_much_co2 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_co2.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_co2.png) | Modified | too_much_nitro | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_nitro.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_nitro.png) | Modified | too_much_oxy | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_oxy.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_oxy.png) | Modified | too_much_tox | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_tox.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/breathing.rsi/too_much_tox.png) | Modified

Resources/Textures/Interface/Alerts/hunger.rsi

| State | Old | New | Status | --- | --- | --- | --- | | overfed | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/hunger.rsi/overfed.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/hunger.rsi/overfed.png) | Modified | peckish | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/hunger.rsi/peckish.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/hunger.rsi/peckish.png) | Modified | starving | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/hunger.rsi/starving.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/hunger.rsi/starving.png) | Modified

Resources/Textures/Interface/Alerts/pressure.rsi

| State | Old | New | Status | --- | --- | --- | --- | | highpressure1 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/pressure.rsi/highpressure1.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/pressure.rsi/highpressure1.png) | Modified | highpressure2 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/pressure.rsi/highpressure2.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/pressure.rsi/highpressure2.png) | Modified | lowpressure1 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/pressure.rsi/lowpressure1.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/pressure.rsi/lowpressure1.png) | Modified | lowpressure2 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/pressure.rsi/lowpressure2.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/pressure.rsi/lowpressure2.png) | Modified

Resources/Textures/Interface/Alerts/temperature.rsi

| State | Old | New | Status | --- | --- | --- | --- | | cold1 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/temperature.rsi/cold1.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/temperature.rsi/cold1.png) | Modified | cold2 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/temperature.rsi/cold2.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/temperature.rsi/cold2.png) | Modified | cold3 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/temperature.rsi/cold3.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/temperature.rsi/cold3.png) | Modified | hot1 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/temperature.rsi/hot1.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/temperature.rsi/hot1.png) | Modified | hot2 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/temperature.rsi/hot2.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/temperature.rsi/hot2.png) | Modified | hot3 | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/temperature.rsi/hot3.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/temperature.rsi/hot3.png) | Modified

Resources/Textures/Interface/Alerts/thirst.rsi

| State | Old | New | Status | --- | --- | --- | --- | | overhydrated | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/thirst.rsi/overhydrated.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/thirst.rsi/overhydrated.png) | Modified | parched | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/thirst.rsi/parched.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/thirst.rsi/parched.png) | Modified | thirsty | ![](https://raw.githubusercontent.com/space-wizards/space-station-14/a3edf04dd3f7cf34bc77bf953722ddc1d8b2a8f0/Resources/Textures/Interface/Alerts/thirst.rsi/thirsty.png) | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/thirst.rsi/thirsty.png) | Modified

Resources/Textures/Interface/Alerts/fire.rsi

| State | Old | New | Status | --- | --- | --- | --- | | fire | ![]() | ![](https://raw.githubusercontent.com/Flareguy/space-station-14/b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea/Resources/Textures/Interface/Alerts/fire.rsi/fire.png) | Added

Edit: diff updated after b17a22ba1c7a0d15b2b45e8dc3810fdff4b939ea

UbaserB commented 3 days ago

I dont like the transition on the flashing of the little warning symbol in the corner for each one

K-Dynamic commented 3 days ago

I dont like the transition on the flashing of the little warning symbol in the corner for each one

I don't like it either but I think it's useful since it's easy for less-experienced players to miss the alerts

That or we add a flashing symbol on alert change that goes away after 3 seconds or so

SpaceRox1244 commented 3 days ago

In terms of at-a-glance readability, at a glance all of these statuses look like rectangles first. I think side icons are more readable when they have strong silhouettes.

ScarKy0 commented 3 days ago

I really liked the bleed one being like a bar of how badly youre bleeding :(

Doru991 commented 3 days ago

I think it's a bit hard to tell what the hunger ones actually are at a glance.

deltanedas commented 3 days ago

pressure gauges are hard to read

Djungelskog2 commented 3 days ago

I heavily dislike the food/water ones, they just look ugly with the colouring and I cant tell whats on the plate in the food ones.

lzk228 commented 3 days ago

new alerts are vice-versa less readable because of a lot of different colors and flashings

slarticodefast commented 3 days ago

Yeah, I agree with the others. These are really hard to read because of all the colors and all icons having the same shape. Before the shape would quickly tell you which status it was at a glance. I would rather go in the other direction, remove the colored background squares where possible and show only the information necessary. A good example for this is the bleeding icon which perfectly shows you the intention behind it as well as the current level.

muburu commented 3 days ago

the atmos alerts that flash on a black background seems very hard to read (a frame of it being pure black is strange)

the hunger icon seems strange to me as it's not immediately readable as food (more plate than food), our current hunger one reads nicely as a cheeseborger which you know is food

the thermostat color should be blue for low temperature since it makes it cartoonishly obvious that it's cold

the fire alert should be more fire than background

Pumkin69 commented 1 day ago

i dislike the direction with a lot of these ESPECIALLY the bloodloss one. The current red drop that fills up more and more is WAY WAY WAY more user friendly and easy to assess at a glance. The other ones are too contrasty or hard to understand at a glance.

ps3moira commented 11 hours ago

I like most of these changes except for pressure, bleeding, and hunger alerts as those are hard to read and understand what they mean.