Double-clicking any item in the "spawn tiles" menu in mapping mode throws an exception

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.71k stars 3.43k forks source link

Double-clicking any item in the "spawn tiles" menu in mapping mode throws an exception #3938

Closed TimrodDX closed 3 years ago

TimrodDX commented 3 years ago

How to reproduce:

Start SS14 in your dev environment.
Go into mapping mode on a new map.
Click the "spawn tiles" option in the spawn menu.
Double-click any item in the tiles menu.
The game will throw a seemingly fatal exception.

20kdc commented 3 years ago

This might be solved by https://github.com/space-wizards/RobustToolbox/pull/1755 but I'm unsure. There are definitely very related bugs that I solved with that, but I don't know if this specific one was.

TimrodDX commented 3 years ago

Nope, I just updated my dev environment (and all submodules) and it looks like the crash still happens.

PaulRitter commented 3 years ago

a stacktrace would be interesting since i cant test it rn

20kdc commented 3 years ago

Notably, while it was merged at that point, did you ensure that you used RobustToolbox master (and/or the one with), or the version selected in the current repository state of space-station-14? (keeping in mind the build script will automatically change it back for some reason)?

TimrodDX commented 3 years ago

I think I used the one in the current repository state, but I'm not sure. Turning it from "debug" to "release" makes it so the error isn't fatal, so it's not much of a problem as it turns out.

PaulRitter commented 3 years ago

I think I used the one in the current repository state, but I'm not sure. Turning it from "debug" to "release" makes it so the error isn't fatal, so it's not much of a problem as it turns out.

this should already be noted in the mapping doc too that you should always map in release since it catches errors. debug will not do that

20kdc commented 3 years ago

The mapping command also has a warning already for this. However to be fair these exceptions imply underlying problems, so it should still be looked into.

AJCM-git commented 3 years ago

Cant reproduce anymore