space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.71k stars 3.43k forks source link

Move fancy viewport to engine. #4765

Open gradientvera opened 3 years ago

gradientvera commented 3 years ago

Description

MainViewport, ScalingViewport, ViewportManager and the viewport CVars should, in my opinion, be moved to the engine. Right now, OpenDream, a personal project and SS14 all have the same viewport code implementation in content, when it could all be in engine. Now, it should still be 100 % for content to implement its own special viewport, but in this case this implementation is widely used enough that it should be in engine.

PaulRitter commented 3 years ago

Sounds good to me tbh