High-priority systems to ECS

[mirrorcult]

Description

These are some systems that should be prioritized heavily for conversion to ECS/refactoring, since they interface with lots of other things:

• [x] Alerts (#5559)
• [x] Actions (#6791)
• [x] Wires (#7699)
• [x] Inventory (#5807)
• [x] EntityStorage (#9291)
• [x] Hands (#7081)
• [x] Chat (#7337)
• [x] Item/Clothing (#9706)
• [x] Mind / Roles (https://github.com/space-wizards/space-station-14/pull/16826 and https://github.com/space-wizards/space-station-14/pull/19591)
• [x] Objectives (#19967)

There are probably more that I can't think of but those are big (actions alone is blocking a lot of stuff from potentially being done)

[Ygg01]

What about hands and containers. Aren't those last few bastions of EC code in content.

[ElectroJr]

Hands definitely need to be ECS-ed.

bastions of EC code in content.

Containers are currently in engine. Even if you move the logic in ContainerManagerComponent/ContainerHelpers into a system, for the most part I don't think it would significantly impact how systems use containers, so probably not as high priority as alerts, actions & hands?

By "not significantly impact how systems use containers" I mean the general structure of: Ensure container on init, then subscribe to ContainerModifiedMessage events to be notified of when an entity was added or removed.

[Ygg01]

s/Container/Inventory/ or whatever still uses inheritance to share functionality.

[mirrorcult]

inventory and hands, yes. also entitystorage

[Ygg01]

@ElectroJr are hands partially ECSed? I saw #5634

[ElectroJr]

Well once/if its merged they will be 20% more ECS. There's still a lot of work to do, and hands code is still pretty scuffed. But hopefully that PR will at least reduce the workload for a future refactor.

In reality, that PR started because I wanted to change hands in order to get some basic interactions predicted. I just wanna pick up items w/o the awkward delay. In the process, I just ended up moving quite a few functions to the shared hands system & removing some component messages.

[Acruid]

Another high priority is to migrate everything that still uses Component Messages, and then Interface Events, in that order.

[DogZeroX]

Oldchat.

[Macoron]

I'm starting ECSing EntityStorage. Wish me luck.

[vulppine]

wires is done via #7699

[Macoron]

Sadly EntityStorage slain me. I've done like 20% and stuck with IRL issues. No idea when I'll have time to continue it, so if someone want to try it...

[mirrorcult]

another one down #9291

[deltanedas]

@DrSmugleaf i was refactoring some objective condition stuff and got annoyed now i want to refactor it to be ecs should i:

• make objectives entities, their ids listed on the mind component
• make objective conditions entities, their ids listed in the objective component
• both of them

currently i am focusing on conditions

nvm just going all the way now :trollface:

[mirrorcult]

we did it reddit

[VasilisThePikachu]

[DogZeroX]

High-priority systems to FLECS now