search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.53k stars 3.14k forks source link

Connecting to server with no lobby enabled will break if no jobs slots are available #6081

Closed PJB3005 closed 2 years ago

PJB3005 commented 2 years ago

Easiest way to test this is to connect to knightship with a character slot allowing only assistant. You'll get stuck on the connecting screen.

moonheart08 commented 2 years ago

The best fix would probably be to force the lobby?

PJB3005 commented 2 years ago

I should have clarified: if no job slots in your character profile are available. You can have 10 slots open for various jobs but if you only have assistant active and that's not available, it'll break.

Really there are two possible fixes here:

  1. always allow spawning as assistant
  2. spawn as observer instead.
moonheart08 commented 2 years ago

I should have clarified: if no job slots in your character profile are available. You can have 10 slots open for various jobs but if you only have assistant active and that's not available, it'll break.

Really there are two possible fixes here:

1. always allow spawning as assistant

2. spawn as observer instead.

Yea the former would effectively be removing a feature (maps don't have to use assistant at all and aren't even required to have overflow jobs)

ShadowCommander commented 2 years ago

I know Colonial Marines just puts the player back in lobby if none of their preferences get picked. Then they have to pick from late join choices.

e.g. when a player sets marine/assistant to no and enables only Xeno.