Client/server packaging scripts are too SS14-centric

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.7k stars 3.4k forks source link

Client/server packaging scripts are too SS14-centric #6547

Open ike709 opened 2 years ago

ike709 commented 2 years ago

Description

package_client_build.py and package_server_build.py are full of SS14isms like the client & server being called Content.Client and Content.Server.

This really tripped me up when I was messing with OpenDream because I just replaced every assembly name with the OD equivalent and that broke copy_content_assemblies() which expects the source directory to be Content.*

At the very least some better comments pointing out what to change and what not to change would be nice.

ike709 commented 2 years ago

Also the path to the scripts is hardcoded to be the Tools directory iirc. OD didn't even include these until I noticed the watchdog needed them.

ike709 commented 2 years ago

Functional OD changes here: https://github.com/wixoaGit/OpenDream/pull/585