wrexbe commented 2 years ago

This is a list of things that are "frozen" or "restricted". See below for what each term means.

Freezes

PRs involving any of these things may be closed at maintainer discretion until the freeze is resolved. If the freeze is due to an ongoing rework then the rework PR will take precedent and your PR may require reworking prior to merge. As usual your PR is subject to not being merged into the repository, especially if maintainer approval is not sought beforehand.

New songs (lobby, jukebox etc) -
- Any new songs will need to wait until a streaming system is implemented for them to be merged.
New lobby art - We got enough at the moment but if you have a good one ask an art director on Discord for approval first
Guns - Seek maintainer approval beforehand. (Ping @metalgearsloth and @DrSmugleaf)
Clothing variants for mobs - Inconsistently maintaining a lot of clothing sprite variants for species/mobs is not feasible and could have big long-term consequences. Variants will not be accepted until we support displacement masks (unless the variants have a good reason to be or a maintainer approved them). This freeze wont apply for maintaining current variants (like monkey suits).
- Certain species-specific sprites are fine if they literally cant be displacement mapped.
- It is fine for existing round-start species.
New pet clothing - These need to use displacement maps which have yet to be implemented. Gas tank sprites are still allowed.
New pets. While fluff is nice we have enough cargo-obtainable fluff animals and department mascots, to add new animals they must have something interesting like new AI behaviors or spawn in proc gen maps.
Roundstart clothing - Wait for loadouts and don't make someone else have to update your yaml.
Wizard - Needs a design doc. (@keronshb is currently working on this.)
Magic/Spells/Spellbook - Currently refactoring & adding new ones (@keronshb is currently working on this.)
Roundstart / player species such as lizards / humans - There currently no maintainer conscious on what the "minimum" requirements for a round start species is. And as such we decided to freeze them until the species workgroup has been designed.

Restrictions

PRs surrounding any items in these list will be heavily scrutinized or require a design doc, taking longer to be reviewed. Consult a maintainer when making a PR involving these things.

Antagonists - We have had code quality issues with these and the code will be scrutinised much more heavily than normal. (Requires a design doc before being implemented)
Anything touching medical (reagents, entities, etc) due to woundmed coming - Any changes may not be re-implemented in the initial woundmed PR, but can be readded later by each PR author.
Recipes - More of a PSA that microwave recipes are subject to potential deletion in future pending chef refactor.
EMAG INTERACTIONS - we have too many and need to cut down. Needs a design doc.
Item Balance - These will be scrutinized heavily.

metalgearsloth commented 2 years ago

Research - It's going to be replaced by something more interesting so don't build on a stub (code xenoarch or something) Guns - We just culled most of them don't go adding more.

Zumorica commented 2 years ago

~~Instruments - Currently refactoring this entirely and moving all of the networking logic to engine. I'm also refactoring most of the engine MIDI code.~~ I don't have much free time to work on that, so I'm putting this freeze on hiatus for now.

ZeroDayDaemon commented 2 years ago

~~Bartending drinks / reagents / sprites - Undergoing full conversion to /tg/ with the new /tg/ sprites~~

~~https://github.com/space-wizards/space-station-14/pull/9410~~

metalgearsloth commented 2 years ago

Antags - We haven't actually had a meeting since I proposed it so it's tentatively here. Reason is people work on a new antag (gameplay for one person occasionally) instead of job content (gameplay actively in every round for several players) so we continue our spiral of having no job content for departments like science. Fixing an existing antag is okay.

Injazz commented 1 year ago

xenosci was merged so consider lifting freeze from research

metalgearsloth commented 1 year ago

~~do_afters as keron is currently refactoring them to be less poopy.~~

juliangiebel commented 1 year ago

~~Anything related to Machine linking. So using or changing calls to methods of SignalLinkerSystem. I have a refactor PR up that moves linking on top of device networking. #13645~~

EmoGarbage404 commented 1 year ago

~~Gonna ask that people don't touch gamemodes/station events while i work on gamerule refactor.~~

keronshb commented 1 year ago

Restoring the antag freeze.

deltanedas commented 1 year ago

does borging count as species i wanna try it

metalgearsloth commented 1 year ago

does borging count as species i wanna try it

We're discussing freezes more in discord but no. Borgs need to use body system though.

deltanedas commented 1 year ago

yeah ill be basing it off current body rework code, seems like brain will be fun fun fun

EmoGarbage404 commented 1 year ago

~~Requesting that all prs adding new technologies and modifications to the RND system be either merged soon or postponed while i begin work on the research rework.~~

AjexRose commented 1 year ago

Is technology unfrozen since Emo got their tech research rework finished?

EmoGarbage404 commented 1 year ago

Is technology unfrozen since Emo got their tech research rework finished?

Yea

moonheart08 commented 1 year ago

Don't mess with stations or gamemodes at the moment please, reworking how stations work under the hood. This means don't modify the prototypes, mapping is fine and won't interfere with me.

keronshb commented 1 year ago

Added Wizard since it still would require Mind Entities and the highest scrutiny.

Boaz1111 commented 9 months ago

Regarding the freeze on weapons, would a PR making certain weapons(musket, etc.) obtainable via a research be frozen?

keronshb commented 8 months ago

Added item balance because we're not at a place where we have consistency internally.

keronshb commented 7 months ago

Readded Wizard and Magic to freezes

VasilisThePikachu commented 4 months ago

I fat-fingered remove, don't mind me

Everturning commented 1 week ago

@wrexbe loadouts have been in for a while now will you edit the roundstart clothing thing

VasilisThePikachu commented 1 week ago

@wrexbe loadouts have been in for a while now will you edit the roundstart clothing thing

I can do it. Maints can edit issues.

I will ask first. So one moment

space-wizards / space-station-14

Current Freezes and PR restrictions #8524

Freezes

Restrictions