space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.71k stars 3.42k forks source link

Being at maximum thirst (red "Parched") makes your game mispredict movement or something #9648

Closed Myctai closed 1 year ago

Myctai commented 2 years ago

Description

Being at maximum thirst (red "Parched") makes your game mispredict movement or something. This seems to be noticeable only with high ping. If you reach "Parched", movement becomes extra painful. You are not only slow, but when you release movement key, you rubberband back a bit.

Reproduction

  1. Do glorious 200 ms ping gaming
  2. Ipecac self into "Parched" or just neglect your character
  3. (Optionally) eat something to fix hunger just to be sure it's thirst slowdown to blame
  4. Suffer as you move with game rubberbanding you back tiny bit whenever you release movement key.

Additional context Does not seem to apply to hunger's slowdown. Only thirst.

asperger-sind commented 2 years ago

It's a weird bug, happened to me about 7 times total, but it's really inconsistent, some maps for some ungodly reason didn't have this whatsoever, and it's both hunger and thirst in my experience, and sometimes the bug just doesn't happen even if the conditions are met.

Myctai commented 2 years ago

I for some reason see it happen just for thirst.

metalgearsloth commented 2 years ago

Probably fixed in https://github.com/space-wizards/space-station-14/pull/9656

Myctai commented 2 years ago

Played two long games with 365f388b8e6aadc9cc782c3f7f16f244f8a26c64 in effect, still did see some rubberbanding when neglecting food and water, however not super consistently. Either not fixed or has something to do with hunger too.

metalgearsloth commented 2 years ago

hunger clientside was refreshing movespeedmodifiers but does nothing with the information so there's 2 issues:

  1. Is that some of the movespeedmodifiers still aren't predicted. The server sends the modifiers as a "just in case" which was getting bulldozed because of hunger and never updated because the client didn't know about some modifiers.
  2. Nutrition in general needs to be moved to shared.
Myctai commented 2 years ago

Been a good while since I experienced this, probably fixed?..

Myctai commented 2 years ago

Nevermind, still seems to happen. Saw this occur with non-red hunger but red thirst once again as usual.