Inconsistent usage of "Centcom" and "Centcomm"

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.62k stars 3.28k forks source link

Inconsistent usage of "Centcom" and "Centcomm" #9807

Open Myctai opened 2 years ago

Myctai commented 2 years ago

Description

Inconsistent usage of "Centcom" and "Centcomm". Which one is true one? Capitalization-wise as well? grep -iR "centcom" reveals both being in use. Seeing:

Centcom
Centcomm
CentCom
CentComm

Reproduction Run grep on repo.

Emisse commented 2 years ago

means central command, whichever you want to use i guess

ike709 commented 2 years ago

Several SS13 servers actually lint to make sure it's always the correct spelling "CentCom" as part of their CI testing.

Myctai commented 2 years ago

Anyone wants me to make massive PR replacing everything to CentCom?

Peptide90 commented 2 years ago

Anyone wants me to make massive PR replacing everything to CentCom?

Looks good to me, feel free to take it :)

Myctai commented 2 years ago

centcomm.spacestation14.io

It's everywhere! I'll CentCom-ise only stuff that won't break stuff. CentCom, as used by tgstation - is this final?

metalgearsloth commented 2 years ago

The CDN is called centcomm
There's still 47 references in the codebase to centcomm.

I think we should just revert and go for 2 m's.

Myctai commented 2 years ago

...or get new domain with one m, plus rename surviving things I did not touch in order to avoid breaking maps, configs and other PRs.

Myctai commented 2 years ago

There's still 47 references in the codebase to centcomm.

Want me to push more commits addressing that to PR #9970?

I can:

Rename centcomm.yml
Change CVar name
Change that ~~one variable~~three variables in Content.Server/Shuttles/Systems/ShuttleSystem.EmergencyConsole.cs making up majority of those "references"
Even change URL once I get confirmation there's centcom.spacestation14.io active

EmoGarbage404 commented 2 years ago

...or get new domain with one m, plus rename surviving things I did not touch in order to avoid breaking maps, configs and other PRs.

Getting a new domain is just silly. Revert the pr and then use CentComm, as that's clearly what is intended (see: url).

As an afternote, i hate CentCom. CentComm with two "m"s forever.

Myctai commented 2 years ago

CentComm was rarest of them all. Sure?

Myctai commented 2 years ago

Funny: https://wiki.spacestation14.io/w/index.php?title=CentCom&action=history Someone better make ultimate decision as I've been met with silence when I went "CentCom, as used by tgstation - is this final?"

I am in favor of CentCom, as used by tgstation. But we are not tgstation and totally not copying tgstation. My intention with PR #9876 and PR #9970 was to turn everything CentCom, skipping things that are not visible to players but likely to break stuff (and arguably those three variables in single file are unlikely to break anything, so I gonna go ahead and push commit to second unmerged PR addressing that bit).

Myctai commented 2 years ago

so I gonna go ahead and push commit to second unmerged PR

And done: 445ea5a14b93913cc7c685f822881e05008b2292

Peptide90 commented 1 year ago

Centcomm map seems the last usage of this (that github search can find). Looks like the previous changes were merged so Centcom it is?

Only other references are in workflows, Github\Content.Shared\CCVar\CCVars.cs and ShuttleSystem.EmergencyShuttle.cs

QuietlyWhisper commented 1 year ago

Slightly related idk if its an issue but telecoms vs telecomms might also come up

AlbertSnows commented 11 months ago

Do we want to include changing the changelog?

QuietlyWhisper commented 11 months ago

We're still seemingly having issues with which name is correct on this new pr related to the issue. Maints should probably state a correct name in stone and revert the other prs if need be...

QuietlyWhisper commented 11 months ago

Got the answer at https://github.com/space-wizards/space-station-14/pull/21108#issuecomment-1771962208

Zylofan commented 1 week ago

I'm new here and looking for my first task, so I might not know what I am talking about. But, shouldn't this be closed now? It looks like the issues was handled and merged.

0x6273 commented 1 week ago

I'm new here and looking for my first task, so I might not know what I am talking about. But, shouldn't this be closed now? It looks like the issues was handled and merged.

I think the pr you're refering to only partially addressed it?