search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.56k stars 3.18k forks source link

Round report can get wonky with reporting #9936

Open Myctai opened 2 years ago

Myctai commented 2 years ago

Description

Round report can get wonky with reporting. Issue #9935 is not the single thing adminbus can cause. Adminbus from previous round somehow carried over to my round report! Don't have the round ID, but first I played as latejoin musician, only to be turned into syndie few minutes in with 3 kill objectives + glorious. There were syndies, nukies and zombies. A mess. Round 12611 was the one for which screenshots are made. Here I latejoined as musician again, got syndie'd again, this time it's stay alive, protect and jetpack theft objectives.

At the end, report contains two entries for me! How the hell did my greentext (that did not even show in Secret extended round report with zombie traitor nukies mess) carry over?

Reproduction

Screenshots (I am Lindy Young on both screenshots of same round report) 12611_1 12611_2

Additional context what is this i don't even

EmoGarbage404 commented 2 years ago

This just seems like admin stuff?

Myctai commented 2 years ago

Thing that might have contributed: I have not restarted my client between those two rounds.

Myctai commented 2 years ago

This just seems like admin stuff?

moony at work. But pretty sure greentext completely unrelated to round for which report is generated should not show up.

EmoGarbage404 commented 2 years ago

I dont understand what this issue is even referring to

Myctai commented 2 years ago

Round report contains stuff related to things I did as adminbus antag in different round. That's the bug.

drakewill-CRL commented 2 years ago

(that did not even show in Secret extended round report with zombie traitor nukies mess)

If the first round didn't report, that means the rule wasn't on, and the list of traitors probably didn't clear out because the mode wasn't picked (and therefor Ended() wasn't called). The second round DID roll traitors for the mode, and that caused the report to occur, with a very long list of traitors from both rounds.

PaulRitter commented 2 years ago

yep, this is an issue with the "Make Traitor"-Verb not enabling the traitor gamemode, hence the list of traitors not getting cleared at the end of the round.

cc @moonheart08