iajoiner commented 2 months ago

Background and Motivation

We already have SmallInt / i16, Int / i32, and BigInt / i64 data types supported. Adding an additional TinyInt / i8 data type would be helpful to some users and would additionally have (minor) performance benefits with those columns.

Changes Requested

[ ] Add a TinyInt variant to the various *Column* enum types.
[ ] Add a branch for handling TinyInt everywhere that SmallInt, Int, and BigInt are handled.
[ ] Add unit tests covering the additional code.

NOTE: be sure keep individual PRs small and self-contained. All net-new code should be tested within the PR.

EDIT: clarification

I've seen several attempts at this issue, and most have the following concern: there aren't any tests around using +, -, =, >, *, etc. on TinyInt columns.

In other words, I'm not convinced that the following query will execute properly if a, b, and c are TinyInt columns:

SELECT a*b+b+c FROM table WHERE a>b OR c=4

It might be the case that there is code in place to do this. However, there should be unit tests providing evidence that this is the case.

At a minimum, in order to close this ticket we need to have at least one integration test showing end-to-end behavior with TinyInt columns and a non-trivial query that requires computation involving TinyInt.

Dustin-Ray commented 2 months ago

Thanks for adding this, should be straightforward enough to add it to the column types and then fill everything out. A good strategy is to do a grep/search in the repo for something like "SmallInt" to find all of the places where it will need to be added.

JayWhite2357 commented 1 month ago

/bounty $100

algora-pbc[bot] commented 1 month ago

💎 $100 bounty • Space and Time

Steps to solve:

Start working: (Optional) Comment /attempt #154 with your implementation plan. Note: we will only assign an issue if you include an implementation plan with a time estimate. Additionally, to be assigned an issue, you must have previously contributed to the project. You can still work on an issue and submit a PR without being assigned.
Submit work: Create a pull request including /claim #154 in the PR body to claim the bounty
Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to spaceandtimelabs/sxt-proof-of-sql!

Add a bounty • Share on socials

c0d33ngr commented 1 month ago

/attempt #154

Options

Cancel my attempt

Dustin-Ray commented 1 month ago

@c0d33ngr please feel free to reach out with any questions, there are some nuances to this change that might warrant clarification.

c0d33ngr commented 1 month ago

Yes, I'll if I need clarification

On Thu, Sep 26, 2024, 8:37 PM Dustin Ray @.***> wrote:

@c0d33ngr https://github.com/c0d33ngr please feel free to reach out with any questions, there are some nuances to this change that might warrant clarification.

— Reply to this email directly, view it on GitHub https://github.com/spaceandtimelabs/sxt-proof-of-sql/issues/154#issuecomment-2377784296, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZKEA4QCHGTMXZH6JOJ5SDTZYRPBHAVCNFSM6AAAAABODOZQCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXG44DIMRZGY . You are receiving this because you were mentioned.Message ID: @.***>