[x] I have run the ci check script with source scripts/run_ci_checks.sh.
Rationale for this change
OrderByExec (to be added), GroupByExec and SortMergeJoinExec (to be added) all depend on correct sorting of rows. Hence we move them together. Meanwhile a bug was found in compare_indexes_by_owned_columns_with_direction causing negative decimals to be considered larger than positive ones. Hence we fixed it and modified a test to check for that.
What changes are included in this PR?
move ordering-related manipulations from group_by_util.rs and owned_column.rs to order_by_util.rs
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.Rationale for this change
OrderByExec
(to be added),GroupByExec
andSortMergeJoinExec
(to be added) all depend on correct sorting of rows. Hence we move them together. Meanwhile a bug was found incompare_indexes_by_owned_columns_with_direction
causing negative decimals to be considered larger than positive ones. Hence we fixed it and modified a test to check for that.What changes are included in this PR?
group_by_util.rs
andowned_column.rs
toorder_by_util.rs
Yes.