spaceandtimelabs / sxt-proof-of-sql

Space and Time | Proof of SQL
Other
2.65k stars 93 forks source link

refactor!: move ordering-related code to `order_by_util.rs` && fix an issue with decimals #388

Closed iajoiner closed 3 days ago

iajoiner commented 6 days ago

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

OrderByExec (to be added), GroupByExec and SortMergeJoinExec (to be added) all depend on correct sorting of rows. Hence we move them together. Meanwhile a bug was found in compare_indexes_by_owned_columns_with_direction causing negative decimals to be considered larger than positive ones. Hence we fixed it and modified a test to check for that.

What changes are included in this PR?

github-actions[bot] commented 3 days ago

:tada: This PR is included in version 0.50.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: