Fix name of "state.icon.closed" field - Githubissues

spaceapi-community / spaceapi-rs

Rust types and serialization for the Space API.

https://crates.io/crates/spaceapi

Apache License 2.0

6 stars 9 forks source link

Fix name of "state.icon.closed" field #111

Closed Xiretza closed 2 years ago

Xiretza commented 2 years ago

The state.icon object contains two fields open and closed; the latter is typoed as close in this library, making deserialization fail.

I have used #[serde(rename)] for now to avoid a breaking change; the field itself should probably eventually be renamed to closed.

Checklist

[x] Tests added if applicable
[ ] README updated if applicable
[x] CHANGELOG updated if applicable
[x] If a commit includes a breaking change, include the string [breaking-change] somewhere in the commit message

dbrgn commented 2 years ago

LGTM, thanks!