search

spaceapi-community / spaceapi-rs

Rust types and serialization for the Space API.
https://crates.io/crates/spaceapi
Apache License 2.0
6 stars 9 forks source link

addded OpenStreetMap Link #112

Closed mrtuxa closed 1 year ago

mrtuxa commented 1 year ago

I added the value osm_link

Checklist

dbrgn commented 1 year ago

Hi, thanks for the PR! This value (location.osm_link) is not standardized (see https://spaceapi.io/docs/). Furthermore it's entirely redundant, as any SpaceAPI client can simply generate an OSM link from the coordinates provided in the location.lat and location.lon (or location.address) fields. Keep in mind that the SpaceAPI endpoint is primarily made for consumption by software, not by humans.

Thus I'll close this PR. If you want to standardize this field, the proper place would be https://github.com/spaceapi/schema. If you want to use this field as a custom extension, you are free to do so in a modified version of spaceapi-rs or any other type of endpoint!