spaceapi-community / spaceapi-server-rs

Rust library to easily implement your own SpaceAPI server.
https://crates.io/crates/spaceapi-server
Apache License 2.0
9 stars 6 forks source link

Replace iron with hyper + routerify #112

Open rnestler opened 2 years ago

rnestler commented 2 years ago

This is just a very raw POC to replace iron by directly using hyper with routerify. The simple static version produces some JSON, but there would obviously still a lot of work needed.

I want to clarify a few things first:

Checklist

dbrgn commented 2 years ago

Are we OK with this stack?

I think using hyper directly is a valid choice for a small application. The tricky thing might be clean handling of resources, i.e. the Redis connection pool.

Alternatives that would be worthwhile to check out: I'd say axum, warp or actix-web.

Are we OK with moving everything to async? This also needs changes for the users of the library.

Yeah, we just bump the major version. I think async is here to stay.

dbrgn commented 2 years ago

@rnestler what's the status on this? 🙂 Do you plan to continue the work, or should I try to pick up?

rnestler commented 2 years ago

@dbrgn Yes I plan to continue on it :slightly_smiling_face: But it might take some time...