MR211 Push #279

Closed treasuretron closed 4 years ago

In GitLab by @richbodo on Oct 22, 2018, 19:08

This merge is required for news and video templates and the icons:

https://gitlab.com/spacebase/spacebase/merge_requests/211/pipelines

In GitLab by @StephenCataldo on Oct 24, 2018, 19:01

This is tagged RFP, but is anything involved besides Mathew approving the merge (as set up, it requires his approval)?

In GitLab by @richbodo on Oct 25, 2018, 17:15

I don't think anything is required aside from that. Unless you see a red flag in the checkins.

Hrm....I'm going to have to figure out how to override this one. Shoot. I can't set approvals required to zero, nor can I remove or change the approver.

O.k. the thing to do here is to create a new MR, merge it, and push it. That's the real task, here. We can close this one when we're done.

In GitLab by @StephenCataldo on Oct 25, 2018, 17:19

I believe that Mathew has set it so his approvals are required for automatic merges, and that he can undo this probably with a click. I might be able to do a merge by hand even with this setting, I'm not sure.

In GitLab by @richbodo on Oct 25, 2018, 17:34

O.k. yeah, I get this. I removed the requirement that Matt approve merge requests. You're good to go, Steve.

In GitLab by @StephenCataldo on Oct 25, 2018, 19:14

assigned to @StephenCataldo

In GitLab by @StephenCataldo on Oct 31, 2018, 16:47

On dev, figuring out the nocaptcha problems before we should test and push this live

In GitLab by @jayelless on Nov 6, 2018, 19:36

This fix appears to have been merged to dev and pushed to production. I recommend that this issue is closed.

In GitLab by @jayelless on Nov 6, 2018, 19:36

closed

In GitLab by @richbodo on Nov 7, 2018, 13:28

James, this is awesome, but we do need to QA news and video on production at this point. Those URLs should be active. Whenever we have a push like this one of a major feature, we should have a QA label on some issue, somewhere, that indicates whether the QA state is requested or approved.

In GitLab by @thomasmurphy on Nov 7, 2018, 17:08

assigned to @richbodo and unassigned @StephenCataldo

In GitLab by @thomasmurphy on Nov 7, 2018, 17:08

Hi Rich, from my perspective we should reopen this ticket and assign the UAT task to you, sound good?

In GitLab by @thomasmurphy on Nov 7, 2018, 17:08

reopened

In GitLab by @richbodo on Nov 7, 2018, 17:46

marked this issue as related to #255

In GitLab by @richbodo on Nov 7, 2018, 17:46

marked this issue as related to #256

In GitLab by @richbodo on Nov 7, 2018, 17:47

Thomas, I added the QA-Prod label to the two feature tickets that were deployed in this one: #255 and #256 both of which I'll work with Em and Eric.

So I'll add those as references, close this one and work those two with Em and Eric this week.

Thanks.

In GitLab by @richbodo on Nov 7, 2018, 17:47

closed

spacebase / spacebasenz

MR211 Push #279