Setup MVP default search (289)

[treasuretron]

In GitLab by @thomasmurphy on Nov 26, 2018, 22:25

[treasuretron]

In GitLab by @thomasmurphy on Nov 26, 2018, 22:25

changed title from Setup MVP default search to Setup MVP default search{+ (289)+}

[treasuretron]

In GitLab by @thomasmurphy on Nov 27, 2018, 20:45

created branch 289-setup-mvp-default-search-289

[treasuretron]

In GitLab by @thomasmurphy on Nov 27, 2018, 20:45

mentioned in merge request !230

[treasuretron]

In GitLab by @thomasmurphy on Nov 27, 2018, 21:01

mentioned in merge request !231

[treasuretron]

In GitLab by @thomasmurphy on Nov 29, 2018, 19:33

mentioned in merge request !233

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 17:58

mentioned in merge request !240

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 18:33

mentioned in commit 036d457ebdcb2a83f411c786f9df839f51e24341

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 18:33

closed via merge request !240

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 22:52

mentioned in merge request !242

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 23:20

Whenever I merge and test that an issue works on the platform merge environment, then approve the merge, then platform deletes the environment, deleting evidence of the positive test. I am also tracking progress of the testing and the merges on the merge request tickets, and because it creates a new ticket for each merge request which hides all my notes. So I am going to keep a deployment progress log on the issue ticket, which is persistent.

Last progress was James and I attempted an automatic (gitlab GUI) merge request, which rejected it on the basis that there were merge conflicts. It prompted us to perform a manual merge, which succeeded, but it only succeeded because it overwrote many files the feature branch (289) without warnings or prompts, so that composer.json no longer had all the modules which were present and working on the same branch locally. This was because we didn't run composer install after the manual merge, so the site looked like it was still working, when in fact it was doomed to a slow death.

We then performed a revert to the commit before the merge, and pushed that back to origin. I have now performed a 5th merge request (242) which went ahead without errors (gitlab and platform.sh pipelines completed successfully) all functionality as expected on https://pr-242-tlrdb6y-ensz4qdpjmziw.us.platform.sh

So I will now complete the merge request.

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 23:20

mentioned in commit da875bc48a265b2f870a193bfcff97dee196e7ce

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 23:29

Features are now as expected on https://dev-54ta5gq-ensz4qdpjmziw.us.platform.sh No major errors on a full cache clear and cron run. Performing a production merge request next.

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 23:39

pipeline for https://us.platform.sh/projects/ensz4qdpjmziw/environments/pr-243 is now in progress.

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 23:49

https://pr-243-mo67wri-ensz4qdpjmziw.us.platform.sh Is up and performing as expected. Cleared all caches, ran cron, inspected the logs... It's now throwing a whole bunch of new php errors of the form https://pr-243-mo67wri-ensz4qdpjmziw.us.platform.sh/admin/reports/dblog/event/476342

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 23:53

Cleared all the logs, ran cron again and looking a lot cleaner, probably old errors brought in with the production database.

[treasuretron]

In GitLab by @thomasmurphy on Dec 4, 2018, 23:55

mentioned in merge request !243