search

spacebase / spacebasenz

Website for SpaceBase New Zealand
http://dev-spacebasenz.pantheonsite.io/
GNU General Public License v2.0
0 stars 0 forks source link

Implement Contribution Credits on User Profiles #304

Open treasuretron opened 4 years ago

treasuretron commented 4 years ago

In GitLab by @richbodo on Dec 19, 2018, 17:32

Following along with the MVP requirements of this spec:

For the MVP, we need the following basic functionality:

Initial Contribution Types:

There are two types of contribution credits that need to be tracked on user profiles and awarded credit in the MVP:

  1. Any content created by users and published by admins: Events, Blogs, Videos, etc.

  2. Filling out a user profile completely is a contribution.

Notes on the big picture:

Contribution Types:

The number and type of contributions that add value to SpaceBase NZ is larger than the above list, and we plan to grow the list of tracked contributions to cover as best we can the real value provided by contributions.

Tracking things like filling out a user profile completely (all required fields) likely gets implemented differently from tracking a built-in content list on a per user basis.

Integration with other systems:

Implmementation of this will be addressed in another ticket on general principle, but we are going to mention it in this first one. As stated in the spec, we want to update a list of contributions, held somewhere in the drupal db, on a regular basis (probably daily), so that list can be consumed by other systems. Might be good to plan ahead for that.

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Dec 19, 2018, 18:23

@richbodo so that the MVP work is compatible with future aspirations, could you explain more about how contribution credits relate to voting for and supporting projects in future?

treasuretron commented 4 years ago

In GitLab by @richbodo on Dec 19, 2018, 18:59

changed the description

treasuretron commented 4 years ago

In GitLab by @richbodo on Dec 19, 2018, 19:00

Added a link to the spec in the description, @thomasmurphy.

I'm working on shoring up the specs for contribution credits and projects right at the moment.

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Dec 19, 2018, 21:09

@richbodo my question came after reading the spec.

treasuretron commented 4 years ago

In GitLab by @richbodo on Dec 19, 2018, 22:26

@thomasmurphy. I'm writing up a new rev of the Project and Contrib_Credits specs right now. I'll chime in here and add more to the wiki shortly.

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Dec 20, 2018, 20:34

Switching to high priority for first task "All content contributions show up on the users public profile as links."

treasuretron commented 4 years ago

In GitLab by @richbodo on Dec 24, 2018, 16:29

changed the description

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Jan 17, 2019, 03:48

I've found some unnecessary complexity in the way the authoring system has been built that affects this.

1) You have author fields alongside Drupal's built-in author field. They are both called author fields, but have different machine names and functions.

2) each content type is using a different custom author field (i.e. machine_name) which breaks how views would find the relationship between content and referenced users, if that is indeed how you want contribution credits to work. What I will start with is a view block on user profiles just for blogs which reference the current user as an author, but if we want to continue down this road I suggest we delete all the other author user reference fields and just have one.

This first version of this is now available for review at https://pr-256-pqobadq-ensz4qdpjmziw.us.platform.sh/u/thomas-murphy

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Jan 27, 2019, 20:28

assigned to @starshyyne

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Jan 27, 2019, 20:30

@starshyyne I've put this on the same branch as "301-Custom-Captcha-question-system" as they are both quite small issues

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 7, 2019, 00:43

mentioned in merge request !260

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 7, 2019, 01:11

closed via merge request !260

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 7, 2019, 01:11

mentioned in commit c9638fa13f794187ff03e42910d3672379b9af14

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 11, 2019, 18:24

reopened

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 11, 2019, 21:31

@richbodo just looking into extending the list of contributed content to all content types, and I have something I need clarification on. There are three different ways content authorship is defined

events,resources, basic pages, partners, forum topics, slides, video

Only have a default Drupal Author field, which can only reference one user.

news articles have a field_na_authors field which can reference multiple users and a default Drupal Author field and

blog posts have a field_bp_authors which can reference multiple users and a default author field.

I had tentatively assumed that all content had custom author fields of the form "field_content-type_authors" after seeing it on blogs and news articles, but it turns out after a full review that most only have the default Drupal system.

What I suggest we do in the first release is to base the contributed content to list all content with the current user in the default Drupal author field, which means we can list all the content types in the existing view field, a very easy win, but this would mean users who were listed as co-authors would not have their content show up. Alternatively I can create 3 separate views, one for blogs, a clone of that for news articles and a third for all the content types which only have the default author field, and combine all three in one block. Does that sounds suitable? Are there any other content types which you don't want me to include on the third view?

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 11, 2019, 23:14

Just to complicate matters further, it appears that New Articles have three author field locations:

  1. The default Drupal field (visible)
  2. field_na_author (this has data populated for the 3 nodes, but is overridden to be hidden from the node edit form so can't be used in future)
  3. field_na_authors (this is also hidden from the form, but doesn't have data)

I suggest we delete the field_na_authors entirely, and treat field_na_author like the field_bp_authors. Was there feature documentation for this previous work?

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 12, 2019, 22:33

mentioned in merge request !266

treasuretron commented 4 years ago

In GitLab by @richbodo on Feb 21, 2019, 15:47

removed milestone

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Mar 27, 2019, 19:02

based on the prioritisation on 15/3/19 this issue is now 14/20 and not expected to happen within the current contract.