spacebase / spacebasenz

Website for SpaceBase New Zealand
http://dev-spacebasenz.pantheonsite.io/
GNU General Public License v2.0
0 stars 0 forks source link

Behat search at 6 scenarios (2 passed, 4 failed) #315

Open treasuretron opened 4 years ago

treasuretron commented 4 years ago

In GitLab by @StephenCataldo on Jan 10, 2019, 17:41

Listed in wiki as working, restore.

(Working, other than not sure about #310 should be a pass or fail as it works now.)

treasuretron commented 4 years ago

In GitLab by @StephenCataldo on Jan 10, 2019, 17:45

marked this issue as related to #306

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Jan 21, 2019, 22:01

Hi @StephenCataldo could you be more specific about the search functionality you are testing for, please? We've changed some of that and will continue to in the following few weeks.

treasuretron commented 4 years ago

In GitLab by @StephenCataldo on Jan 21, 2019, 22:19

Sounds good — most of it is already tweaked (on my testing branch) to match how the searches work now.

1) How do you document this, so the tests can match the code and the tests? If you're changing the searches I should stop working on tests, unless someone sends me the specs.

2) I'm noticing when I go to the homepage, and enter "Search," the results are ... there's no title on the page. See https://gitlab.com/spacebase/spacebase/issues/310 . Can you just do that search and look at the results, and tell me if what we have now is right (with no title) or needs fixing?

This isn't a huge deal, once the tests pretty much work, it's easy to adjust the tests.

The searches do things like search for a person via a substring, and search for an organization in different ways. Pretty basic. If you change the id's of the buttons, the tests need to be tweaked. Moving forward it's not very hard to just run the test, notice the buttons that don't fire, and rename them.

treasuretron commented 4 years ago

In GitLab by @StephenCataldo on Jan 21, 2019, 22:20

changed the description