spacebase / spacebasenz

Website for SpaceBase New Zealand
http://dev-spacebasenz.pantheonsite.io/
GNU General Public License v2.0
0 stars 0 forks source link

Update contrib module leaflet latest version #331

Closed treasuretron closed 4 years ago

treasuretron commented 4 years ago

In GitLab by @jayelless on Feb 27, 2019, 21:07

It appears that commit 923719a "update for Rich to do work" on 22nd Feb updated the leaflet module from 8.x-1.0-beta15 to 8.x-1.3 (along with numerous other module updates). There appear to have been significant changes between 8.x-1.2 and 8.x-1.3 to leaflet, with advise posted on the module page that settings will be lost and need to be re-applied.

There are also structural changes within the module, so that a simple update results in drupal encountering fatal errors form "file not found" conditions.

There is a need to ensure that this update has not lost configuration detail, and to provide release notes to allow the update to be applied to existing feature branches.

This commit (included in branch 306-behat-rebuild) has been merged into the dev branch, so all existing feature branches are potentially affected.

treasuretron commented 4 years ago

In GitLab by @jayelless on Feb 27, 2019, 22:45

I have updated the composer files to recognise the update to leaflet 8.x-1.3 and rebuild the map views display to use the updated version.

I have created a merge request, so this update should be merged into dev asap.

treasuretron commented 4 years ago

In GitLab by @jayelless on Feb 27, 2019, 22:46

mentioned in merge request !272

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Feb 27, 2019, 23:14

mentioned in merge request !254

treasuretron commented 4 years ago

In GitLab by @jayelless on Feb 28, 2019, 01:02

Release notes.

If merging this branch into an existing feature branch, the following step apply:

  1. Uninstall leaflet_views and leaflet_markercluster
  2. Uninstall leaflet.
  3. clear the caches.
  4. Perform the merge.
  5. Import config (will re-install the above three modules and recreate the map view with correct settings).
treasuretron commented 4 years ago

In GitLab by @jayelless on Mar 3, 2019, 17:01

Because a full revert of the commit "2ffe240: Refs #306 Fix composer.json error, rebuild composer.lock, and merge to dev" was performed (refer commit c77d109: Revert "Refs #306 Fix composer.json error, rebuild composer.lock, and merge to dev"), this issue is no longer relevant.

Changing this issue to one to update leaflet.

treasuretron commented 4 years ago

In GitLab by @jayelless on Mar 3, 2019, 17:02

changed title from {-Check and reconfigure the leaflet settings-} to {+Update contrib module leaflet latest version+}

treasuretron commented 4 years ago

In GitLab by @jayelless on Mar 22, 2019, 19:58

The branch 325-leaflet is now ready yo merge into dev. The leaflet version has been updated to 8.x-1.4

treasuretron commented 4 years ago

In GitLab by @jayelless on Apr 8, 2019, 20:19

Have created a new branch 325-leaflet-v2 from latest dev to resolve the problems with merging.

treasuretron commented 4 years ago

In GitLab by @jayelless on Apr 8, 2019, 20:20

mentioned in merge request !287

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Apr 9, 2019, 21:30

closed via merge request !287

treasuretron commented 4 years ago

In GitLab by @thomasmurphy on Apr 9, 2019, 21:30

mentioned in commit 6dc6ba058e7668173b1bbb7fdc4965724238297d