Remove hamburger menu #358

Closed treasuretron closed 4 years ago

In GitLab by @richbodo on Mar 15, 2019, 06:27

Just disable this for now. We will need a place to put links to things like the wiki, reporting pages, etc. that we want everyone to be able to navigate to in an intuitive way, but maybe we'll put a menu across the top of the page for those or something later on.

In GitLab by @thomasmurphy on Mar 17, 2019, 21:49

@richbodo isn't this a duplicate of #323?

In GitLab by @richbodo on Mar 21, 2019, 19:31

Not unless I read #323 totally differently than it seems to read.

323 was a ticket that said you would create a proposal in the form of a new feature branch for a new menu system.

This ticket says to shitcan the hamburger menu.

I think you guys did propose a new layout, then emailed us about it, and we had an email conversation on it, which ended with our side asking: "Can you guys explain the reason behind the new layout". #323 got closed and the email thread died.

I think I remember that email thread and the internal conversation about the proposal. You forwarded a screenshot showing that Laura had proposed just moving all of the menu items to the top menu bar as text items.

We know that Laura is a pro and probably had excellent reasoning, but to us as laymen, the design wasn't compelling. I'm sure if we knew the reasons and were able to discuss them, we would be able to engage more on menu/nav design.

In GitLab by @thomasmurphy on Mar 21, 2019, 19:47

@richbodo the first presented prototype was to just get rid of the burger menu, I just sent through Laura's designs because she had historically made them (very quickly) after an internal discussion, so I thought you might as well have them FYI. We never did any dev based on them after the discussion at the relevant sprint meeting.

The 323 branch has work on it to: 1) clean up cross browser css bugs on the grid menu 2) add the menu icon module so you can edit/extend the menu on production without front end dev work - plus dependent front end work 3) switch to a 3 column grid to a) allow additional items in the menu without using up too much vertical space and b) match the 3x3 grid icon link.

This is currently on dev, feedback very welcome. We can go back to a 2 column grid, but I'll add the new projects link (#341) on the 339 branch and see how it works with 7 menu items before making a decision, I suggest.

In GitLab by @richbodo on Mar 21, 2019, 20:12

Ah, o.k. I didn't get all that from the description on #323. I'll take a look at dev and give you some feedback on the new grid menu and the menu_icon_module if I can figure it out.

In GitLab by @thomasmurphy on Mar 27, 2019, 18:21

change visible on https://pr-283-b55kqtq-ensz4qdpjmziw.us.platform.sh/

In GitLab by @thomasmurphy on Mar 27, 2019, 18:21

closed

spacebase / spacebasenz

Remove hamburger menu #358

323 was a ticket that said you would create a proposal in the form of a new feature branch for a new menu system.