search

spaceconcordia / space-jobs

1 stars 0 forks source link

shawnstoute branch #6

Open SpaceShawn opened 9 years ago

SpaceShawn commented 9 years ago

What is this branch for? Are the changes useful, and should they be merged into the development branch?

It's good to name branches after a feature change, a development pattern, a quality/stability standard, or some other descriptive measure.

The development branch is okay because it implies that the code may not be stable. I don't want to get overly fussy but it's a bit confusing for other developers and we like to be more clear with our annotations in Git.

Please rename it, merge it, and/or delete it, thanks!

shawn97 commented 9 years ago

Austin added it, I will check it out On 3 Feb 2015 20:59, "SpaceShawn" notifications@github.com wrote:

What is this branch for? Are the changes useful, and should they be merged into the development branch?

It's good to name branches after a feature change, a development pattern, a quality/stability standard, or some other descriptive measure.

The development branch is okay because it implies that the code may not be stable. I don't want to get overly fussy but it's a bit confusing for other developers and we like to be more clear with our annotations in Git.

Please rename it, merge it, and/or delete it, thanks!

— Reply to this email directly or view it on GitHub https://github.com/spaceconcordia/space-jobs/issues/6.

SpaceShawn commented 9 years ago

Okay, I'll reassign it, that would be nice if you could go over it quickly just to confirm and Austin can delete it.

shawn97 commented 9 years ago

Okay,

I went over,

it looks very good, and more efficient than what I had.

Austin, if you can do the same for the others.

A-Hubbell commented 9 years ago

Sure thing I'll see what other jobs can be refactored, I just added the development branch to follow the format of space-payload which used a development branch and a master. In the future I'll use more descriptive branch names.

A-Hubbell commented 9 years ago

My bad, I meant to make a development branch just for the job I was working on but I made it for space-jobs

SpaceShawn commented 9 years ago

No problem, it's just a good policy to be as descriptive as possible. Since Git is all about collaborative editing, it really helps to be clear and make it easier for other devs to follow what's going on.

When you have a moment please merge, delete, or rename the shawnstoute branch as appropriate

SpaceShawn commented 9 years ago

The shawnstoute branch is still visible, can you please go ahead and delete if ready?

Thanks