I2CRead() function does not appear to actually ready

[A-Hubbell]

There doesn't seem to be any code doing any actual reading in the I2CRead() function. The function is called by readDevice() in the same lib, so if it is not working then both functions are broken.

[SpaceShawn]

From what I can tell it does seem to do a read at this line: https://github.com/spaceconcordia/space-lib/blob/master/utls/src/i2c-device.cpp#L36 - let me know if I misunderstood the problem

However I don't see any tests for this here besides checking file access. @harley1011 could you please make a few changes to the library:

• write unit tests to verify the strings returned by I2CRead. @A-Hubbell can you provide @harley1011 I2C file contents from ConSat-1 for sample data?
• test the bounds you set for MAX_ERROR_MSG_SIZE and I2C_MAX_BUF_SIZE (how were these decided?)
  • we have some global constants that might be useful in these instances, consider switching to CS1_MAX_LOG_ENTRY for MAX_ERROR_MSG_SIZE (it's easier to control and test behavior across the project using the globals)
• write tests for I2CWriteToRTC
• what is the status of I2CWrite? We would like to avoid having dead code in the master branch, please move this code to a separate branch or complete and test the function

Thanks!