spaceconcordia / spaceconcordia.github.io

Contains the static website for the Space Concordia society

6 stars 5 forks source link

Killed the Rocketry, Spacecraft and Special Projects pages #10

Closed alienorlgrst closed 7 years ago

alienorlgrst commented 7 years ago

I had thought the dropdown menues were also clickable and acted as regular buttons. But they don't. There's now no way of accessing the main division pages. I don't know how to make the dropdown items also act like a regular button..

alibreaksthings

plzfixit

PeterGhimself commented 7 years ago

started development on reviveTeamPages-10

I managed to fix the issue.. I still need to do a tiny bit of cleaning up/refactoring

PeterGhimself commented 7 years ago

Never mind it's too much work I'd have to edit all the html files o.O I'll just open a PR now. The code base needs serious refactoring/reorganization... I'll write up some more issues regarding that later today.

alienorlgrst commented 7 years ago

It's actually all dropdowns**, divisions special projects contact us and about us

n0pan commented 7 years ago

Yup... the code base definitely needs serious refactoring. The menu should be in its own file and be injected into all of the static pages to make it easier to edit.

PeterGhimself commented 7 years ago

@n0pan I was gonna make an issue for this injecting... in general, I'd like make a function called initUI which will do this for every module... Also I'm gonna move the files into folders for clearer organization.. I'll make a separate issue for that. I'm closing this issue now, even though I'll merge the branch later tonight.