Closed PeterGhimself closed 7 years ago
First of all, good job! Fucking good job man.
And yes, you can delete the extra sponsors folder. It was made back when we used to have our sponsors on the front page so they aren't being used right now iirc.
Unfortunately I had to revert the merge of this branch because upon checking out our site, all I saw was the README file... looking into fixing this now
This PR is linked to issue #12
Summary
The main goal was to reorganize the projects folder structure to be neater, and hopefully you can all agree that we should always create new html/css/js files in their respective new folders. I also found that the missing favicon was due to the links pointing to a
favicon.png
instead of afavicon.ico
, so I took the liberty and fixed that in this PR as well.Please give feedback on:
I noticed that there seems to be a folder with images we are not using called
sponsors
(which I have moved intospaceconcordia.github.io/
), as opposed to thesponsors/
folder inspaceconcordia.github.io/img/
, which we most certainly are using. I checked this by recursively grepping for the filenames contained in the not usedsponsors/
.I haven't yet, just in case, but should I delete this folder?This folder has been deleted. If anyone has any further suggestions on changing the folder structures, please let them be known. Here is the current folder structures on this branch:Project Folder Structure