spaceconcordia / spaceconcordia.github.io

Contains the static website for the Space Concordia society
6 stars 5 forks source link

Fix smooth scrolling 23 #24

Closed PeterGhimself closed 7 years ago

PeterGhimself commented 7 years ago

This PR resolves #23

Summary

PeterGhimself commented 7 years ago

@chriskfwoo I suppose it would be a good idea, all though on some pages we have the gmaps loaded between the social media links and the footer. In any case I think it should be handled in another PR since this one is about fixing the smoothscrolling.js file.

And as for your comment on render-blocking: I like having all the scripts in one place. What if I just added an async attribute to any non-jQuery js files? Alternatively I could move it the jquery/smoothscrolling.js to the bottom of the page.. But if this render-blocking is really a problem, shouldn't we then move all the <script> tags to the bottom?

n0pan commented 7 years ago

I think moving the <script> tags to the bottom would be a good idea.