Fix broken footer link 25

spaceconcordia / spaceconcordia.github.io

Contains the static website for the Space Concordia society

6 stars 5 forks source link

Fix broken footer link 25 #26

Closed PeterGhimself closed 7 years ago

PeterGhimself commented 7 years ago

This PR resolves #25

Please review PR 24 first before reviewing this PR. Once PR 24 is merged, the diffs for this PR will change and make more sense.

Summary

created new file utilities to store all helper functions as properties of global object Util
fixed broken footer links by changing footer.js accordingly

PeterGhimself commented 7 years ago

So after merging, something went wrong. Even though I had no errors while testing locally, there were issues with utilities.js. If anyone has any thoughts on why, it is much appreciated. I will look into this in the meantime. Oh yeah I git reset --hard to the merge commit of pull request #23 and git push --force to get the site back to working state.