search

spacecowboy / Feeder

Android RSS reader app
GNU General Public License v3.0
1.64k stars 99 forks source link

feat: add select all button to delete feed #234

Closed dracarys18 closed 8 months ago

dracarys18 commented 8 months ago
spacecowboy commented 8 months ago

You could keep it simple (because it's tricky) and just make the select-all button be dumb: it always selects all.

dracarys18 commented 8 months ago

You could keep it simple (because it's tricky) and just make the select-all button be dumb: it always selects all.

I would prefer it to be a checkbox with deselect. Because let's say I selected all of the entries with Select All button and now I have to deselect them then I have to do it one by one which is not really convenient. What are your thoughts?

spacecowboy commented 8 months ago

I would prefer it to be a checkbox with deselect. Because let's say I selected all of the entries with Select All button and now I have to deselect them then I have to do it one by one which is not really convenient. What are your thoughts?

Sure, I don't mind. But it's tricky as I said.

dracarys18 commented 8 months ago

Some additional changes after adding the derivedState mentioned previously

I have resolved them please check

spacecowboy commented 8 months ago

Looks good now @dracarys18 Thanks for your contribution!