search

spacecowboy / Feeder

Android RSS reader app
GNU General Public License v3.0
1.64k stars 99 forks source link

Show unread article count in title #300

Closed svenjacobs closed 5 months ago

svenjacobs commented 5 months ago

As suggested here I started with a rather simple feature and added an option to display the unread article count in the title bar.

If you like I can further improve this PR and make the unread count a little bit smaller?

Hope you like it.

spacecowboy commented 5 months ago

Nice work @svenjacobs . Overall it looks good. Run ./gradlew ktlintformat on it though

svenjacobs commented 5 months ago

Run ./gradlew ktlintformat on it though

Done. I fixed the formatting.

svenjacobs commented 5 months ago

Going to fix the tests, too 👀

svenjacobs commented 5 months ago

Tests are fixed.

svenjacobs commented 5 months ago

@spacecowboy Unfortunately I found a bug with this implementation. When a group is selected, the unread count of "all feeds" will be displayed in the title and not the one of the group. I will have a look 👀

spacecowboy commented 5 months ago

@spacecowboy Unfortunately I found a bug with this implementation. When a group is selected, the unread count of "all feeds" will be displayed in the title and not the one of the group. I will have a look 👀

Yes that's correct. getUnreadCount does not take tags into account. Simply passing the tag along should fix that.

svenjacobs commented 5 months ago

You're right. The fix was pretty simple.