spacecowboy / Feeder

Android RSS reader app
GNU General Public License v3.0
1.63k stars 99 forks source link

Open drawer after hitting fab button to mark all articles read #375

Closed Matth7878 closed 1 month ago

Matth7878 commented 1 month ago

Checklist

App version

2.6.32

Where did you get the app from

Other

Feature or improvement you want

It would a great QOL improvment if when hitting fab button to mark all read then drawer was opened. You could then choose another tag to continue reading.

Why should this be added?

When you mark all articles read you end up on an empty screen where there is nothing to do. To continue reading articles from others tags the only choice is to manually open the drawer. So it would be nice for users if it was opening without having to do it manually to continue reading or to check if other tags with unread article exists.

Screenshots / Drawings / Technical details

No response

sweetman-zz commented 1 month ago

As a suggestion in the same thread I just see that other apps (Feedly) jumps automatically to the next drawer when you mark all feeds read. Then, when you click the last drawer and no more feeds are available, just display the actual message (select another drawer add content). Tony

spacecowboy commented 1 month ago

I think it could be a nice feature.

It could be an setting, but doesn't have to be.

I think this would be a good first issue to work on too.

Matth7878 commented 1 month ago

As a suggestion in the same thread I just see that other apps (Feedly) jumps automatically to the next drawer when you mark all feeds read.

If this option exists it would be nice to be a different setting. I don't read tagged categories alphabetically. Next tag I am reading depends on how many unread articles exists and what interests me more.

spacecowboy commented 1 month ago

As a suggestion in the same thread I just see that other apps (Feedly) jumps automatically to the next drawer when you mark all feeds read.

If this option exists it would be nice to be a different setting. I don't read tagged categories alphabetically. Next tag I am reading depends on how many unread articles exists and what interests me more.

This feature is about opening the navigation drawer when the fab is pressed, nothing more

maksimowiczm commented 1 month ago

Sorry for off-topic.

While working on the issue, I noticed that you're using a custom navigation drawer. This implementation isn't perfect and comes with some strange behavior (I'm not sure if it's intended) such as allowing the feed to be scrolled while the drawer is open.

I assume that at the time of implementation, the androidx.compose.material3 version was not yet available. Do you plan on migrating to the compose navigation drawer?

spacecowboy commented 1 month ago

I assume that at the time of implementation, the androidx.compose.material3 version was not yet available.

Yes. Something like that. If I recall correctly, the material3 drawer did not behave as the guidelines said it should. It could have been a tablet specific issue. But there was some issue at least.

Do you plan on migrating to the compose navigation drawer?

No active plans as such

AlbertoFabbri93 commented 2 days ago

I think the "mark all as read" button should not open the drawer when the user is in the "all feeds" tab. Open the drawer in that case is useless as all the other tabs are empty as well.

Lyndeno commented 1 day ago

I think the "mark all as read" button should not open the drawer when the user is in the "all feeds" tab. Open the drawer in that case is useless as all the other tabs are empty as well.

I agree

spacecowboy commented 3 hours ago

I think the "mark all as read" button should not open the drawer when the user is in the "all feeds" tab. Open the drawer in that case is useless as all the other tabs are empty as well.

Could be a reasonable exception yes. Please open a new feature request for that