spacecowboy / Feeder

Android RSS reader app
GNU General Public License v3.0
1.63k stars 99 forks source link

Missing icon in feed's list #404

Closed christop69 closed 3 weeks ago

christop69 commented 3 weeks ago

Checklist

App version

2.6.33

Where did you get the app from

Google Play

Android version

14

Device model

Samsung A55

First occurred

No response

Steps to reproduce

Some feeds don't have an icon (it's not about the dark theme with an all black icon, it's the same with the white theme). How explain ? Would it be possible to choose and force one ?

Example of feed without icon : https://www.begeek.fr/feed

Screenshot_20241029_093939_Feeder

Expected behaviour

No response

Current behaviour

No response

Logs

No response

spacecowboy commented 3 weeks ago

Not a bug. The site simply doesn't have an icon defined on their site.

Feeder uses either the favicon or the apple-...-icon one.

christop69 commented 3 weeks ago

I am not an expert in favicon but begeek.fr seems to have one if I test with http://www.google.com/s2/favicons?domain=begeek.fr

Any idea ?

firefox_ZM2zXuUP8d
spacecowboy commented 2 weeks ago

no idea

christop69 commented 2 weeks ago

Possible bug ? So maybe you could reopen the issue ?

spacecowboy commented 2 weeks ago

No.

I looked at the feed. It doesn't link to the HTML site. Only itself.

So feeder can't know what the site address is.

christop69 commented 2 weeks ago

OK I understand for begeek

One last point and I'll stop bothering you ^^ :

For lesnumeriques.com the feed is

num

The link seems to be OK ? But the icon that's displayed (ugly) isn't that of the link or of the “icon” tag, but that of the “logo” tag, it seems ?

spacecowboy commented 2 weeks ago

Yes. That's the one which is picked.

christop69 commented 2 weeks ago

Yes. That's the one which is picked.

Don't you think it would be more appropriate to pick the icon tag ? Or ideally to give the user the choice when adding the feed ?

spacecowboy commented 2 weeks ago

There is nothing saying that one will be of higher quality than the other.

And no, I don't think users should get to pick.