The mark all as read button opens up the subscribed list

SDee001 commented 3 days ago

Checklist

[X] I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
[X] I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
[X] I will describe the problem with as much detail as possible.
[X] If the bug only to occurs with a certain feed, I will include the URL of that feed.

App version

2.7

Where did you get the app from

Other

Android version

no

Device model

samsung f12

First occurred

after update or one day ago

Steps to reproduce

Open app
Tap mark all as read button
It opens the subscription list

Expected behaviour

It should juat mark all as read and make the screen nothing to read appar

Current behaviour

Opens up the subscription list

Logs

No response

spacecowboy commented 3 days ago

Not a bug.

@maksimowiczm implemented this change.

spacecowboy commented 3 days ago

See previous feature request: https://github.com/spacecowboy/Feeder/issues/375

joavd commented 3 days ago

Facing the same here. After reading through the linked ticket I'm still kinda lost.

What exactly do you need to do to mark things as Read (and remove them from the list) after hitting the "Mark all as read" button?

For me it opens up the drawer but then there's only an option to switch tabs, nothing else.

wiredOr commented 3 days ago

Issue happens for me as well on pixel 8 pro, Android 15.

trlef19 commented 2 days ago

It's indeed a feature. I don't like it though. It's confusing. Maybe add a toggle for it? I don't get the point either :(

joavd commented 2 days ago

How come it's a feature though? It's not marking stuff as Read, it only opens the drawer.

Or is it a bug only for some?

trlef19 commented 2 days ago

It does both for me

spacecowboy commented 2 days ago

How come it's a feature though? It's not marking stuff as Read, it only opens the drawer.

Or is it a bug only for some?

It IS marking them as read but you don't notice it.

If you un-toggle showing read items it will become very clear to you.

I think there is a clear difference here depending on how you use Feeder.

If you usually hide read items, then hitting the FAB will remove everything from the screen so it makes sense that you'd want to open a different feed/tag after that.

If you show read times, maybe you still want to scroll and read something else though. And in that scenario, opening the navigation drawer might seem weird.

Personally I always hide read items.

joavd commented 2 days ago

@spacecowboy makes sense thanks!

But the default behaviour changed, before the update it was marking as read + hiding. Now it doesn't.

Did the settings change or were reset?

trlef19 commented 2 days ago

personally, since i dont have a lot have a lot of feeds, i read them from "all" and then i hit read. So opening the drawer doesnt work for me :((

blair-n commented 2 days ago

I'm having this issue too since yesterday. Clicking "Mark all as read" previously used to also clear all the read conversations. Now it just opens the side drawer.

maksimowiczm commented 2 days ago

I think the issue here is that something went wrong with migrating filter settings in this commit. To fix that, you just need to change the feed filter (disable Read).

spacecowboy commented 2 days ago

@spacecowboy makes sense thanks!

But the default behaviour changed, before the update it was marking as read + hiding. Now it doesn't.

Did the settings change or were reset?

Yes the default setting changed. You never toggled it, so that's why it changed for you.

TBH I did not expect any current user to get their setting changed, so I apologize for that.

blair-n commented 2 days ago

I think the issue here is that something went wrong with migrating filter settings in this commit. To fix that, you just need to change the feed filter (disable Read).

That helps. Thanks so much!

Brottweiler commented 1 day ago

I find this feature highly annoying because I am almost always in the all feeds tab and I do not hide entries that I have read. Maybe it's nice to open the drawer when you have selected a specific feed but it still feels like a setting to change this behaviour would be nice, and don't open the drawer in the all feeds tab.

RMHogervorst commented 4 hours ago

If you un-toggle showing read items it

I don't see this option in settings though .

It is a filter option under the cyclone icon

spacecowboy / Feeder