search

spacecowboy / NotePad

Now under new management
GNU General Public License v3.0
382 stars 158 forks source link

Add Clear button to action bar #379

Closed Ahsieh95 closed 2 years ago

Ahsieh95 commented 7 years ago

Code to add clear complete button in action bar in Xml line 21-27

spacecowboy commented 7 years ago

Thanks for the PR!

This is a duplicate of the menu action present here: https://github.com/spacecowboy/NotePad/blob/master/app/src/main/res/menu/fragment_tasklist.xml#L24

I am also not sure about using an 'X' for this icon, which is one reason why it doesn't have one at the moment. I'd be happy to hear a counter-argument though.

Ahsieh95 commented 7 years ago

I seem to have forgotten to mention this was in response to issue #348. I understand regarding the icon. As a suggestion, would a checked checkbox work in place of the 'X' icon?

spacecowboy commented 7 years ago

Maybe. What do you think of the double checkbox?

ic_done_all

https://github.com/google/material-design-icons/blob/master/action/drawable-anydpi-v21/ic_done_all_black_24dp.xml (needs color flipped to white though)

Ahsieh95 commented 7 years ago

That would work but I feel it's more of a complete all rather than a clear complete.

Ahsieh95 commented 7 years ago

Actually I realise that what I suggested earlier would be more of a complete all. The double checkbox makes more sense.