mntmn
commented
4 years ago Hi, I agree that testing is useful. I would prefer end-to-end integration tests that cover the most essential user stories first.
Example: "Log in, create a space, create a note, write text" or "Share space, open another browser window, check if expected space/content is visible".
If these are written with uncomplicated CSS selectors, the tests are not tightly coupled to the structure of the javascript code, so it can be refactored without having to rewrite tests all the time. I agree that jest is a good solution for this.
I will not enforce TDD in the project, but you are free to use it when introducing new features.
Unit tests and specialized regression tests are fine for algorithmic / rendering / coordinate translation and so on code parts, in my opinion.
JohnMcLear
cynthia-rempel
banglashi
Proposal: create an initial set of tests with Jest (compatible with Vue, one of the major dependencies of spacedeck).
There is substantial code in this project already. Lack of automated tests for that code causes three main risks to be larger than needed:
Resolving this issues is a large amount of work. I suggest it be broken into four steps:
Step 1: create three to five trivial back end unit tests and a similar number of trivial front end tests. These tests will focus on basic aspects of spacedeck functionality.
Step 2: work on creating basic regression tests for the recently fixed star/starburst and multi-user cursor position issues.
Step 3: start driving all further work with test-first approach that backfills regression tests as various parts of the code are touched.
Step 4: work on systematically improving code coverage of the existing code base with automated tests.
This issue should be closed once the initial set of trivial tests is created in Step 1. Step 2 could be written up as one or two separate issues for tracking. Steps 3 and 4 are really separate projects, not just issues.