We have a few clippy warnings and one test has a build error after landing #100.
Our on-pull-request CI job does not run on pull request coming in from forks. That's why it could sneak in unnoticed.
This commit fixes the issues in the code.
I checked GitHub documentation: when we have pull requests incoming from forks, we need to approve workflow runs. When we get PRs from outside collaborator, we should quickly check that they do not make changes to our GitHub workflows, and then it's safe to approve workflow runs on the PR page.
Test Plan: cargo check && cargo test && cargo clippy && cargo build
We have a few clippy warnings and one test has a build error after landing #100. Our on-pull-request CI job does not run on pull request coming in from forks. That's why it could sneak in unnoticed. This commit fixes the issues in the code. I checked GitHub documentation: when we have pull requests incoming from forks, we need to approve workflow runs. When we get PRs from outside collaborator, we should quickly check that they do not make changes to our GitHub workflows, and then it's safe to approve workflow runs on the PR page.
Test Plan:
cargo check && cargo test && cargo clippy && cargo build