search

spacedentist / spr

Submit pull requests for individual, amendable, rebaseable commits to GitHub
https://getcord.github.io/spr/
MIT License
377 stars 33 forks source link

Can't disable test plan checking #112

Closed cjol closed 1 year ago

cjol commented 1 year ago

I'm just giving spr a try, and don't want to use test plans in my commit messages. I've tried to change the configuration settings but it seems to be blocking my commit anyway: 

❯ spr --version
spr 1.3.3

❯ tail .git/config 
[spr]
        githubAuthToken = .....
        githubRemoteName = origin
        githubRepository = powerxai/application-v3
        githubMasterBranch = main
        branchPrefix = spr/cjols/
        requireTestPlan = false
        requireApproval = true

❯ git config --get spr.requireTestPlan  
false

❯ spr diff --all                        
3f5c1c5 fix(alarms): Use all dimensions for Cloudwatch queue metrics
  💔  Commit message does not have a Test Plan!

Am I missing something?

sven-of-cord commented 1 year ago

The requireTestPlan setting was added after the last release. It will become available with the next release.

[EDIT: I made a copy-paste mistake and this comment originally said requireApproval]

cjol commented 1 year ago

I assume you mean the requireTestPlan setting?

sven-of-cord commented 1 year ago

I assume you mean the requireTestPlan setting?

Oops, sorry, yes of course! (I edited my comment above for future readers)

alper commented 1 year ago

What is this test plan thing anyway (is it documented somewhere?) and what does it have to do with this way of working? Can it be made entirely optional?

rockwotj commented 1 year ago

It's documented here: https://getcord.github.io/spr/reference/configuration.html