search

spacedentist / spr

Submit pull requests for individual, amendable, rebaseable commits to GitHub
https://getcord.github.io/spr/
MIT License
377 stars 33 forks source link

Don't fail on requesting reviewers #116

Closed joneshf closed 1 year ago

joneshf commented 1 year ago

It's not always possible to request reviewers, so now we don't fail.

Unless you have admin access to a repo, you cannot request reviewers for a PR. Since there are workflows where not everyone has admin access, and we don't want to fail unnecessarily, we don't make it a requirement that requesting reviewers has to succeed.

This was first raised in https://github.com/getcord/spr/issues/97, and the resolution to only communicate a warning was brought up in https://github.com/getcord/spr/pull/109#discussion_r917668718.

Should close https://github.com/getcord/spr/issues/97.

Test Plan:

  1. First, ensure you don't have write access to a repo.
  2. Create a commit.
  3. Run spr diff
  4. [ ] The PR should be opened and the command should only warn when it cannot request reviewers.
joneshf commented 1 year ago

Thanks for the review/merge!