search

spacedentist / spr

Submit pull requests for individual, amendable, rebaseable commits to GitHub
https://getcord.github.io/spr/
MIT License
377 stars 33 forks source link

diff: actually fetch eligible reviewers in the background where the comment says so #121

Closed sven-of-cord closed 1 year ago

sven-of-cord commented 1 year ago

We need to spawn a future to kick off the async function.

Test Plan: cargo check, and submit this commit with spr diff, requesting reviewers in the original commit message

sven-of-cord commented 1 year ago

Looking at this again, there is very little point in kicking off the eligible_reviewers task early. We hardly do anything before we await the task. And we don't await at all, so yes, very much pointless.