search

spacedentist / spr

Submit pull requests for individual, amendable, rebaseable commits to GitHub
https://getcord.github.io/spr/
MIT License
377 stars 33 forks source link

Reviewers not updated with spr --update-message #150

Open schrockn opened 1 year ago

schrockn commented 1 year ago

Hello! First of all thanks for the wonderful tool.

I frequently have the workflow where I make an initial commit and then want to update the set of reviewers later. I'd love to be able to do this via the commit message just like I can do on the initial commit. I prefer using the commit message as the source of the truth rather than the GitHub UI

However after the initial commit it appears that the Reviewers: field is ignored. Another indication of this is that if you edit the Reviewers field only and run spr diff --update-message it says there is no update necessary.

If this is deliberate decision, no worries and feel free to close.

See a test PR: https://github.com/dagster-io/dagster/pull/10751

sven-of-cord commented 1 year ago

Not a deliberate decision, more like a blind spot in the implementation. Thanks for raising this!

I don't know when/if I find time to do something about it myself, but PR's welcome.

schrockn commented 1 year ago

Ok great thanks for the context. I might look at taking this on over the Christmas break as an excuse to learn some Rust.