search

spacedentist / spr

Submit pull requests for individual, amendable, rebaseable commits to GitHub
https://getcord.github.io/spr/
MIT License
376 stars 33 forks source link

Bug: landing a PR after being accepted then re-ordered does not work #166

Open dukeofcool199 opened 1 year ago

dukeofcool199 commented 1 year ago

when a PR that is higher up on the stack is accepted, and then re-ordered so that it can be landed, complains about not being accepted. (this only happens for people who do not have permission to override the peer review requirements)

steps to reproduce:

  1. create commit A
  2. create commit B -- NOTE: these are independent commits
  3. spr diff --all
  4. accept Commit/PR B
  5. re-order local main so that B is below A
  6. spr land commit B
  7. get error stating that PR has not been accepted

seems to be similar if not the same issue as https://github.com/getcord/spr/issues/163#issue-1685426732, but I thought I should put up my own issue in case they were different.