spacedentist / spr

Submit pull requests for individual, amendable, rebaseable commits to GitHub
https://getcord.github.io/spr/
MIT License
376 stars 33 forks source link

[Critical Bug] Error when updating an existing PR #175

Open dukeofcool199 opened 11 months ago

dukeofcool199 commented 11 months ago

i get the following error when trying to run spr diff on an existing pr

🔁 Commit was changed - updating Pull Request #378 🛑 GitHub: Validation Failed Documentation URL: https://docs.github.com/rest/pulls/pulls#update-a-pull-request Errors:

indigoviolet commented 11 months ago

@sven-of-cord I just got a very similar error while trying to spr land:

❯ spr land
dc3afed Minor bugfixes for Doc and Engine.instantiate_doc
  #️⃣   Pull Request #18
  🛫  Getting started...
  🛑  GitHub: Validation Failed
      Documentation URL: https://docs.github.com/rest/pulls/pulls#update-a-pull-request
      Errors:
      - {"code":"invalid","field":"base","message":"Proposed base branch 'refs/heads/main' is invalid","resource":"PullRequest"}
eko-wibowo commented 10 months ago

I just got this for spr land not clear why it says invalid base :-/ any workaround?

❯ spr land
05b36a4 [SI-97] Integrate new scheduler in chat
  #️⃣   Pull Request #5489
  🛫  Getting started...
  🛑  GitHub: Validation Failed
      Documentation URL: https://docs.github.com/rest/pulls/pulls#update-a-pull-request
      Errors:
      - {"code":"invalid","field":"base","message":"Proposed base branch 'refs/heads/main' is invalid","resource":"PullRequest"}
SlowSnowFox commented 10 months ago

a temporary fix is to go onto GitHub and change the base branch manually to be main. Only do this after you landed the dependent PR's. Then spr land works.

SlowSnowFox commented 9 months ago

building from source completely removes this problem. So removing the latest version from homebrew(1.3.4) and building from scratch (1.3.5-beta.1) is the way to go.