spacedentist / spr

Submit pull requests for individual, amendable, rebaseable commits to GitHub
https://getcord.github.io/spr/
MIT License
376 stars 33 forks source link

[docs] Need clarification on how to insert a commit into the middle of an ongoing stacked PR review #199

Open koachan opened 1 week ago

koachan commented 1 week ago

Say I have a commit history that looks like this:

xxxxxx Commit A
yyyyyy Commit B

Then I submit them for review with spr diff --all. However, during the review it become clear that I should make another commit ("Commit C") inbetween A and B. So my goal is to change the commit history into something like this:

xxxxxx Commit A
zzzzzz Commit C
yyyyyy Commit B

How do I do this? Would inserting the new commit with git rebase -i then rerunning spr diff --all works, or do I need to do other things to achieve that?