spacedockapp / spacedock

Star trek
Apache License 2.0
11 stars 10 forks source link

NX-01 cannot equip Enhanced Hull Plating #120

Closed bmcgough closed 9 years ago

bmcgough commented 10 years ago

Perhaps to be fixed in new data model, but the NX-01's special ability is to equip Enhanced Hull Plating specifically.

rtsuk commented 10 years ago

Nope, not fixed. I'll take a look at it.

rtsuk commented 10 years ago

This one is tough. Space Dock really isn't set up to equip an upgrade to a ship that doesn't have a matching slot. I think the best bet is to use the notes and additional points feature to indicate you are using it. Which suggests Android needs this feature sooner rather than later. I'm going to muse on this a bit more but I think "no plan to fix" might end up being the answer.

bmcgough commented 10 years ago

From what I remember reading about the new data model, a keyword match would work for this, wouldn't it (NX-01 and EHP entries both have a keyword like "NX01EHPFREE" that lets them match)?

Maybe the new data model is a ways off?

Thank you!

rtsuk commented 10 years ago

I've put the new data model work on hold as I'm not sure I'll be able to complete it. Instead I'm going to make the current one work as best as possible.

The problem is that even in the new data model there was the idea of a slot that took on of a set of types. So for the NX do you add a tech slot that can only have this one specific upgrade? It also gets complicated when something else adds a tech slot to the NX. Now you have two tech slots, one of which can only have one item.

It's not impossible to implement, it just doesn't seem worth it.

bmcgough commented 10 years ago

Sure, I can see that.

Maybe more rope is the solution. Rules-enforcing building is really nice, but as it gets more complicated, I'm sure people want the new ships and new cards faster than it takes to implement along with more complex logic fixes.

What about a rules 'advisory' along with a 'let me do whatever I want' switch? Users could turn off the build rules in cases like this (on a per-ship basis?) and then have tools to add whatever slots and other things they want. Spacedock would then just highlight that this ship is not rule-checked.

I don't know if that would be easier to do than some other logic fix, but it does seem like a long-term feature rather than a short-term fix.

rtsuk commented 10 years ago

Not a bad idea, although there's a lot of UI work to do on the mobile platforms for it to work. There's currently no way to add something for which there isn't already a slot. Certainly not worth it for just this one ship/item combo when the additional points/notes approach will work fine.

bmcgough commented 10 years ago

Agreed.

Have you given any thought to a web-based version? HTML5 in-the-browser and all? Could be a unified solution across OS X/Android/iOS/Windows...? Plus..., you know,... ponies!

rtsuk commented 10 years ago

I would be delighted if someone wanted to create an HTML version of Space Dock. I'd even generate the data model for them, if they wanted. I won't be me, though.

DrNicket commented 9 years ago

I have an idea for the "more rope" idea that may not require much of a UI change at all.

Add a toggleable option where [share] Copy Print are at the bottom. Perhaps a Padlock icon. When unlocked, every ship is given +1 slot of each type (including Borg), but in Red (or otherwise differentiated). For every red slot filled, an additional red slot of that type is added. This would permit build workarounds. When output/shared, there could be a text disclaimer added.

Do you think this is possible/feasible/practical?

rrgeorge commented 9 years ago

I have come up with an solution to this issue. As far as I know this is really the only legal situation where you'd need to add an upgrade that doesn't have a slot.