search

spacedockapp / spacedock

Star trek
Apache License 2.0
11 stars 10 forks source link

Lore/Hugh special abilities not working in android #78

Closed tblackwe closed 10 years ago

tblackwe commented 10 years ago

Captain abilities were not implemented.

rtsuk commented 10 years ago

I missed them on Mac/iOS as well. I'll update the data file for both as a first step.

rtsuk commented 10 years ago

This is fixed for Mac and iOS. I also added test cases to the specials.spacedocksquads file, but there's two things preventing us from using it to test Android. One is that I'm not sure if the tests are working under Android Studio, and the other is that I modified the test case on Mac to sort the upgrades in both the data and equippedShip by id and cost so that they won't break due upgrade order differences on the platforms.

The code in question is the listTester method in class TestSquad.

tblackwe commented 10 years ago

Double checking my understanding of Hugh. He doesnt take a penalty for any Borg Faction upgrades, correct? It isnt Borg Upgrade Type, which makes sense since there are no non-borg ships with borg slots. The card says Borg, not the borg symbol.

On Sun, Jul 13, 2014 at 11:22 AM, Rob Tsuk notifications@github.com wrote:

This is fixed for Mac and iOS. I also added test cases to the specials.spacedocksquads file, but there's two things preventing us from using it to test Android. One is that I'm not sure if the tests are working under Android Studio, and the other is that I modified the test case on Mac to sort the upgrades in both the data and equippedShip by id and cost so that they won't break due upgrade order differences on the platforms.

The code in question is the listTester method in class TestSquad.

— Reply to this email directly or view it on GitHub https://github.com/rtsuk/spacedock/issues/78#issuecomment-48843417.

rtsuk commented 10 years ago

That matches my guess.

I also allow Lore to install any Elite Talent upgrade, because at the moment all the ones that are restricted are restricted by faction. We'll, if you consider "Tholian" a faction. Which its not. Sigh. That's how I'm shipping it, anyway.

tblackwe commented 10 years ago

There is a hull value limited talent. I forget which right now. On Jul 13, 2014 2:01 PM, "Rob Tsuk" notifications@github.com wrote:

That matches my guess.

I also allow Lore to install any Elite Talent upgrade, because at the moment all the ones that are restricted are restricted by faction. We'll, if you consider "Tholian" a faction. Which its not. Sigh. That's how I'm shipping it, anyway.

— Reply to this email directly or view it on GitHub https://github.com/rtsuk/spacedock/issues/78#issuecomment-48847522.

rtsuk commented 10 years ago

Isn't that Phaser Strike, a weapon?

rtsuk commented 10 years ago

Ah, First Strike. I don't think I implemented that at all.

rtsuk commented 10 years ago

OK, I'm going to deny Lore First Strike and Tholian Puncuality. Anything else come immediately to mind?

tblackwe commented 10 years ago

That looks correct to me.

On Sun, Jul 13, 2014 at 2:16 PM, Rob Tsuk notifications@github.com wrote:

OK, I'm going to deny Lore First Strike and Tholian Puncuality. Anything else come immediately to mind?

— Reply to this email directly or view it on GitHub https://github.com/rtsuk/spacedock/issues/78#issuecomment-48847942.