search

spacedockapp / spacedock

Star trek
Apache License 2.0
11 stars 10 forks source link

In Android When adding an admiral as a captain it gets put in the admiral spot instead #83

Closed tblackwe closed 10 years ago

tblackwe commented 10 years ago

How did I miss that in testing?

rtsuk commented 10 years ago

Testing? Yes, that's an excellent idea. I should do that sometimes too. ;)

rtsuk commented 10 years ago

In fact I did this wrong on Mac and iOS as well. I'm adding the Admirals as Captains to the Captain's list, as I think that's the only way to make it work correctly on Mac and iOS.

tblackwe commented 10 years ago

So implementing similar to how you did the doctor and the EMH? Two entries in data.xml? On Jul 17, 2014 12:40 AM, "Rob Tsuk" notifications@github.com wrote:

In fact I did this wrong on Mac and iOS as well. I'm adding the Admirals as Captains to the Captain's list, as I think that's the only way to make it work correctly on Mac and iOS.

— Reply to this email directly or view it on GitHub https://github.com/rtsuk/spacedock/issues/83#issuecomment-49257779.

rtsuk commented 10 years ago

Yep, one in Captains and one in Admirals. For me it required extra filtering to prevent the Admiral entities from showing up in the Captains list, but not for you I think.

On Jul 17, 2014, at 3:36 AM, Thomas Blackwell notifications@github.com wrote:

So implementing similar to how you did the doctor and the EMH? Two entries in data.xml? On Jul 17, 2014 12:40 AM, "Rob Tsuk" notifications@github.com wrote:

In fact I did this wrong on Mac and iOS as well. I'm adding the Admirals as Captains to the Captain's list, as I think that's the only way to make it work correctly on Mac and iOS.

— Reply to this email directly or view it on GitHub https://github.com/rtsuk/spacedock/issues/83#issuecomment-49257779.

— Reply to this email directly or view it on GitHub.

rtsuk commented 10 years ago

I fixed this with my last commit.