search

spacedockapp / spacedock

Star trek
Apache License 2.0
11 stars 10 forks source link

Cannot Assign Federation Self-Destruct Sequence to a ship captained by Lore. #86

Closed tblackwe closed 10 years ago

tblackwe commented 10 years ago

To be fixed in next release (if the model doesnt change radically):

self_destruct_sequence_71523 needs a unique special id so it can be added to the Lore exception.

rtsuk commented 10 years ago

Why can't Lore install this one?

tblackwe commented 10 years ago

Sorry, you're right. I thought there were other upgrades using it. I missed it in the EquippedShp logic.

On Sat, Jul 19, 2014 at 10:23 AM, Rob Tsuk notifications@github.com wrote:

Why can't Lore install this one?

— Reply to this email directly or view it on GitHub https://github.com/rtsuk/spacedock/issues/86#issuecomment-49510831.

rtsuk commented 10 years ago

Yah, Lore's exception list is for the upgrades he can't install, not the ones he can. Since there's no reason he can't install this one, Self-Destruct Sequence doesn't belong on the upgrade list.

That logic is easily one of the worst methods I've ever written. Twice.